Closed Bug 398017 Opened 17 years ago Closed 17 years ago

nsGenericElement and nsJSEventListener unlink improvements

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: sayrer, Assigned: sayrer)

References

Details

Attachments

(1 file, 1 obsolete file)

While working on a smaller version of bug 397206, I noticed this message in the DEBUG_CC messages: nsCycleCollector: nsGenericElement 0x345eb430 in component 152 was not collected due to missing call to suspect, failure to unlink, or deficiency in traverse that causes cycles referenced only from other cycles to require multiple rounds of cycle collection nsCycleCollector: nsGenericElement 0x345e9650 in component 95 was not collected due to missing call to suspect, failure to unlink, or deficiency in traverse that causes cycles referenced only from other cycles to require multiple rounds of cycle collection nsCycleCollector: nsEventListenerManager 0x345eb460 in component 152 was not collected due to missing call to suspect, failure to unlink, or deficiency in traverse that causes cycles referenced only from other cycles to require multiple rounds of cycle collection nsCycleCollector: nsEventListenerManager 0x345e9680 in component 95 was not collected due to missing call to suspect, failure to unlink, or deficiency in traverse that causes cycles referenced only from other cycles to require multiple rounds of cycle collection nsCycleCollector: nsJSEventListener 0x345eb490 in component 152 was not collected due to missing call to suspect, failure to unlink, or deficiency in traverse that causes cycles referenced only from other cycles to require multiple rounds of cycle collection nsCycleCollector: nsJSEventListener 0x345e96b0 in component 95 was not collected due to missing call to suspect, failure to unlink, or deficiency in traverse that causes cycles referenced only from other cycles to require multiple rounds of cycle collection
Attached patch unlink more things (obsolete) (deleted) — Splinter Review
Assignee: nobody → sayrer
Status: NEW → ASSIGNED
Attachment #282847 - Flags: review?(peterv)
Attachment #282847 - Flags: superreview+
Attachment #282847 - Flags: review?(peterv)
Attachment #282847 - Flags: review+
Attachment #282847 - Flags: approval1.9?
Comment on attachment 282847 [details] [diff] [review] unlink more things The change in nsJSEventListener.cpp isn't needed anymore on trunk. Probably still want the change in nsGenericElement.cpp.
Comment on attachment 282847 [details] [diff] [review] unlink more things a=release drivers
Attachment #282847 - Flags: approval1.9? → approval1.9+
Whiteboard: [needs landing]
Version: unspecified → Trunk
Whiteboard: [needs landing]
Attached patch patch for checkin (deleted) — Splinter Review
Attachment #282847 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: