Boris Zbarsky [:bzbarsky] Reporter
	Description • 17 years ago

STEPS TO REPRODUCE:

1)  javascript:alert(window)
2)  javascript:alert(window + "")
3)  Write a mochitest in which you have a test like:

   is(null, window, "Should be null, for some reason")

EXPECTED RESULTS:  All three give the same string for the window

ACTUAL RESULTS:
1)  Gives "[object XPCCrossOriginWrapper [object Window]]"
2)  Gives "[object Window]"
3)  Gives "[]"

This last particularly bothers me, since I can't tell why that's happening.

	Blake Kaplan (:mrbkap) (inactive) Assignee
	Comment 1 • 17 years ago

#3 happens due to a bug in MochiKit's repr (specifically, its isArrayLike function returns true for window objects, which is incorrect). I'll file that in a second. I have a patch for cases 1 and 2.

	Blake Kaplan (:mrbkap) (inactive) Assignee
	Comment 2 • 17 years ago

If only hg allowed me to give more context to the diff...

The only tricky bit here is that this code is shared by both XPCNativeWrapper whose toString I wanted to leave alone.

With this patch, to verify that you have a XOW from JS, you must do Object.prototype.toString.call(obj).

	Boris Zbarsky [:bzbarsky] Reporter
	Comment 3 • 17 years ago

Comment on attachment 282965 [details] [diff] [review]
Fix

sr=bzbarsky

	Blake Kaplan (:mrbkap) (inactive) Assignee
	Comment 4 • 17 years ago

I filed bug 398118 on the MochiKit issue.

	Blake Kaplan (:mrbkap) (inactive) Assignee
	Comment 5 • 17 years ago

Comment on attachment 282965 [details] [diff] [review]
Fix

This fixes a XOW inconsistency and makes alert(window) and alert(window + '') do the same thing.

	Jonas Sicking (:sicking) No longer reading bugmail consistently
	Comment 6 • 17 years ago

Not a blocker maybe, but since there's a patch, it'd be great to get it in.

	Blake Kaplan (:mrbkap) (inactive) Assignee
	Comment 7 • 17 years ago

Comment on attachment 282965 [details] [diff] [review]
Fix

This will help ease confusion about XOWs and will make us consistent again.

	Mike Beltzner [:beltzner, not reading bugmail]
	Comment 8 • 17 years ago

Comment on attachment 282965 [details] [diff] [review]
Fix

a=endgame drivers for after M9 freeze

	Blake Kaplan (:mrbkap) (inactive) Assignee
	Comment 10 • 17 years ago

Fix checked in.