Closed
Bug 398326
Opened 17 years ago
Closed 17 years ago
[FIX]"ASSERTION: Should be in an update while creating frames" with xul listbox
Categories
(Core :: XUL, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla1.9beta1
People
(Reporter: jruderman, Assigned: bzbarsky)
References
Details
(Keywords: assertion, testcase)
Attachments
(3 files)
|
(deleted),
application/xhtml+xml
|
Details | |
|
(deleted),
text/plain
|
Details | |
|
(deleted),
patch
|
dbaron
:
review+
dbaron
:
superreview+
dbaron
:
approval1.9+
|
Details | Diff | Splinter Review |
Loading the testcase (in Mac trunk debug) triggers:
###!!! ASSERTION: Should be in an update while creating frames: 'mUpdateCount != 0', file /Users/jruderman/trunk/mozilla/layout/base/nsCSSFrameConstructor.cpp, line 6682
This assertion was added in bug 398108.
Flags: blocking1.9?
|
Assignee | |
Comment 1•17 years ago
|
||
See, that's the think. I tried testing listboxes before landing bug 398108 because I expected them to assert... but they didn't. Neither does that testcase, in my build.
What's the stack you see to the assert?
|
Reporter | |
Comment 2•17 years ago
|
||
Stack trace for the first instance of the assertion.
|
|
Assignee | |
Comment 3•17 years ago
|
||
I still don't know why I couldn't reproduce....
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #283293 -
Flags: superreview?(dbaron)
Attachment #283293 -
Flags: review?(dbaron)
|
|
Assignee | |
Updated•17 years ago
|
Priority: -- → P1
Summary: "ASSERTION: Should be in an update while creating frames" with xul listbox → [FIX]"ASSERTION: Should be in an update while creating frames" with xul listbox
Target Milestone: --- → mozilla1.9 M9
|
||
Comment 4•17 years ago
|
||
Comment on attachment 283293 [details] [diff] [review]
Fix
r+sr=dbaron, although we should probably invest in guard objects for this at some point...
Attachment #283293 -
Flags: superreview?(dbaron)
Attachment #283293 -
Flags: superreview+
Attachment #283293 -
Flags: review?(dbaron)
Attachment #283293 -
Flags: review+
|
|
Assignee | |
Updated•17 years ago
|
Attachment #283293 -
Flags: approval1.9?
|
|
||
Comment 5•17 years ago
|
||
Comment on attachment 283293 [details] [diff] [review]
Fix
a1.9=dbaron
Attachment #283293 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Comment 6•17 years ago
|
||
Checked in. Could use a test in layout/crashtests or whatever bug 397725 decides on.
Flags: in-testsuite?
|
|
Assignee | |
Updated•17 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.xul → xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•