Closed Bug 398466 Opened 17 years ago Closed 17 years ago

XBL unlinking triggered hash-table recursion assertion (again)

Categories

(Core :: XBL, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla1.9beta2

People

(Reporter: jruderman, Assigned: peterv)

References

Details

(Keywords: assertion, crash, regression)

Attachments

(3 files, 1 obsolete file)

Attached file stack trace (deleted) —
###!!! ASSERTION: op == PL_DHASH_LOOKUP || RECURSION_LEVEL(table) == 0: 'op == PL_DHASH_LOOKUP || RECURSION_LEVEL(table) == 0', file pldhash.c, line 585 Like in bug bug 398083, I don't have a testcase, but I do have a stack trace (from XPCOM_DEBUG_BREAK=stack). Unlike in bug 398083, the assertion was not followed by a crash; Firefox exited normally.
Yeah, that looks like the thing smaug commented on in bug 398083.
Should add a dep, but I don't recall the bug number.
(In reply to comment #2) > Should add a dep, but I don't recall the bug number. Bug 378866?
Yeah, that's it.
Depends on: 378866
I'm still seeing this occasionally even though the bug this depends on (bug 378866) is fixed. Today, I saw it along with a shutdown crash.
Flags: blocking1.9?
Keywords: crash
Assignee: nobody → peterv
Priority: -- → P2
Target Milestone: --- → mozilla1.9 M10
Flags: blocking1.9? → blocking1.9+
Attached patch v1 (obsolete) (deleted) — Splinter Review
Avoid adding/removing stuff from the hashtables while we're destroying them. Jesse: are you seeing this frequently? If so, could you try out this patch?
Attachment #291324 - Flags: superreview?(jonas)
Attachment #291324 - Flags: review?(jonas)
I'm not seeing this frequently enough to try out a patch and give a useful answer, sorry.
Attached patch v1.1 (deleted) — Splinter Review
Got verbal r/sr=sicking on this one.
Attachment #291324 - Attachment is obsolete: true
Attachment #291387 - Flags: superreview+
Attachment #291387 - Flags: review+
Attachment #291324 - Flags: superreview?(jonas)
Attachment #291324 - Flags: review?(jonas)
Whiteboard: [needs landing]
Status: NEW → RESOLVED
Closed: 17 years ago
OS: Mac OS X → All
Hardware: PC → All
Resolution: --- → FIXED
Whiteboard: [needs landing]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: