Closed
Bug 398505
Opened 17 years ago
Closed 13 years ago
nsMathMLmactionFrame::Init munges style context
Categories
(Core :: MathML, defect)
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: bzbarsky, Assigned: fredw)
References
Details
(Keywords: dev-doc-complete)
Attachments
(2 files)
(deleted),
patch
|
karlt
:
review+
emorley
:
checkin+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
karlt
:
review+
karlt
:
checkin+
|
Details | Diff | Splinter Review |
nsMathMLmactionFrame::Init reresolves its style context after munging an attribute... it's possible to craft style rules so that it'll actually end up with "display: none" after that, but still have a frame. That's bad.
Updated•15 years ago
|
QA Contact: ian → mathml
Assignee | ||
Updated•15 years ago
|
Assignee: rbs → nobody
Assignee | ||
Comment 1•14 years ago
|
||
I suggest to remove the actiontype="restyle". See bug 544036 comment 1
Comment 2•14 years ago
|
||
Agreed.
Assignee | ||
Comment 3•13 years ago
|
||
Assignee: nobody → fred.wang
Assignee | ||
Comment 4•13 years ago
|
||
Assignee | ||
Updated•13 years ago
|
Attachment #555084 -
Flags: review?(karlt)
Assignee | ||
Updated•13 years ago
|
Attachment #555085 -
Flags: review?(karlt)
Comment 5•13 years ago
|
||
Comment on attachment 555085 [details] [diff] [review]
remove nonstandard actiontype "restyle" of maction on MathML demo pages.
>-×××¥ ×¢× ××¢××ר ××× ×ק×× ×××××ר ×צ××× ××× ××××××/××ק××× ××¢×רת RESTYLE:
>+×××¥ ×¢× ××¢××ר ××× ×ק×× ×××××ר ×צ××× ××× ××××××/××ק×××:
>-à¸à¸¥à¸´à¸à¸à¸£à¸à¹à¸«à¸à¸à¹à¹à¸à¹à¹à¸à¸à¸·à¹à¸à¸à¸µà¹à¸ªà¸µà¹à¸«à¸¥à¸·à¸à¸ à¹à¸à¸·à¹à¸ ยà¹à¸/à¸à¸¢à¸²à¸¢ à¹à¸à¸¢à¹à¸à¹ RESTYLE:
>+à¸à¸¥à¸´à¸à¸à¸£à¸à¹à¸«à¸à¸à¹à¹à¸à¹à¹à¸à¸à¸·à¹à¸à¸à¸µà¹à¸ªà¸µà¹à¸«à¸¥à¸·à¸à¸ à¹à¸à¸·à¹à¸ ยà¹à¸/à¸à¸¢à¸²à¸¢ :
Did you check that it is appropriate to remove these words in these languages?
Attachment #555085 -
Flags: review?(karlt) → review+
Updated•13 years ago
|
Attachment #555084 -
Flags: review?(karlt) → review+
Assignee | ||
Comment 6•13 years ago
|
||
(In reply to Karl Tomlinson (:karlt) from comment #5)
> Comment on attachment 555085 [details] [diff] [review]
> remove nonstandard actiontype "restyle" of maction on MathML demo pages.
>
> >-×××¥ ×¢× ××¢××ר ××× ×ק×× ×××××ר ×צ××× ××× ××××××/××ק××× ××¢×רת RESTYLE:
> >+×××¥ ×¢× ××¢××ר ××× ×ק×× ×××××ר ×צ××× ××× ××××××/××ק×××:
>
> >-à¸à¸¥à¸´à¸à¸à¸£à¸à¹à¸«à¸à¸à¹à¹à¸à¹à¹à¸à¸à¸·à¹à¸à¸à¸µà¹à¸ªà¸µà¹à¸«à¸¥à¸·à¸à¸ à¹à¸à¸·à¹à¸ ยà¹à¸/à¸à¸¢à¸²à¸¢ à¹à¸à¸¢à¹à¸à¹ RESTYLE:
> >+à¸à¸¥à¸´à¸à¸à¸£à¸à¹à¸«à¸à¸à¹à¹à¸à¹à¹à¸à¸à¸·à¹à¸à¸à¸µà¹à¸ªà¸µà¹à¸«à¸¥à¸·à¸à¸ à¹à¸à¸·à¹à¸ ยà¹à¸/à¸à¸¢à¸²à¸¢ :
>
> Did you check that it is appropriate to remove these words in these
> languages?
I tried to translate into English with Google translate and that seems to be correct.
Comment 7•13 years ago
|
||
(In reply to Karl Tomlinson (:karlt) from comment #5)
> Comment on attachment 555085 [details] [diff] [review]
> remove nonstandard actiontype "restyle" of maction on MathML demo pages.
>
> >-×××¥ ×¢× ××¢××ר ××× ×ק×× ×××××ר ×צ××× ××× ××××××/××ק××× ××¢×רת RESTYLE:
> >+×××¥ ×¢× ××¢××ר ××× ×ק×× ×××××ר ×צ××× ××× ××××××/××ק×××:
>
> >-à¸à¸¥à¸´à¸à¸à¸£à¸à¹à¸«à¸à¸à¹à¹à¸à¹à¹à¸à¸à¸·à¹à¸à¸à¸µà¹à¸ªà¸µà¹à¸«à¸¥à¸·à¸à¸ à¹à¸à¸·à¹à¸ ยà¹à¸/à¸à¸¢à¸²à¸¢ à¹à¸à¸¢à¹à¸à¹ RESTYLE:
> >+à¸à¸¥à¸´à¸à¸à¸£à¸à¹à¸«à¸à¸à¹à¹à¸à¹à¹à¸à¸à¸·à¹à¸à¸à¸µà¹à¸ªà¸µà¹à¸«à¸¥à¸·à¸à¸ à¹à¸à¸·à¹à¸ ยà¹à¸/à¸à¸¢à¸²à¸¢ :
>
> Did you check that it is appropriate to remove these words in these
> languages?
Exactly what fonts am I supposed to have installed so that this comment makes any sense whatsoever?
Comment 8•13 years ago
|
||
(In reply to Frédéric Wang (:fred) from comment #6)
> I tried to translate into English with Google translate and that seems to be
> correct.
OK. Sounds fine, thanks.
(In reply to Bill Gianopoulos from comment #7)
> Exactly what fonts am I supposed to have installed so that this comment
> makes any sense whatsoever?
I don't think any fonts will. There seems to be an encoding (or similar) problem with Bugzilla's "Edit Attachment As Comment".
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Comment 9•13 years ago
|
||
Where is the 2nd patch supposed to be landing, seeing as the files for it don't exist in m-c?
In instances where non-standard landing of patches is required, please can you add suitable instructions to the whiteboard, to make it easier not only for the person doing the checkin-neededs, but also people doing the subsequent inbound -> m-c merge. Thanks :-)
Status: NEW → ASSIGNED
Comment 10•13 years ago
|
||
Try run for the first patch:
https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=5a17479d7da9
Comment 11•13 years ago
|
||
(In reply to Ed Morley [:edmorley] from comment #9)
> Where is the 2nd patch supposed to be landing, seeing as the files for it
> don't exist in m-c?
>
> In instances where non-standard landing of patches is required, please can
> you add suitable instructions to the whiteboard, to make it easier not only
> for the person doing the checkin-neededs, but also people doing the
> subsequent inbound -> m-c merge. Thanks :-)
I believe the second patch is for the www.mozilla.org webserver.
to be landed relative to:
http://www.mozilla.org/projects/mathml/
I suspect the checkin-needed was probably intended to refer to the first patch only.
Comment 12•13 years ago
|
||
Comment on attachment 555085 [details] [diff] [review]
remove nonstandard actiontype "restyle" of maction on MathML demo pages.
http://viewvc.svn.mozilla.org/vc?view=revision&revision=95002
Attachment #555085 -
Flags: checkin+
Updated•13 years ago
|
OS: Linux → All
Version: 1.8 Branch → Trunk
Comment 13•13 years ago
|
||
Comment on attachment 555084 [details] [diff] [review]
remove nonstandard actiontype "restyle" of maction. r=karlt (bug 398505)
https://hg.mozilla.org/integration/mozilla-inbound/rev/c576f8acafd6
Attachment #555084 -
Flags: checkin+
Updated•13 years ago
|
Keywords: checkin-needed
Target Milestone: --- → mozilla9
Comment 14•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 15•13 years ago
|
||
Documented:
https://developer.mozilla.org/en/Firefox_9_for_developers#MathML
https://developer.mozilla.org/en/MathML/Element/maction#Gecko-specific_notes
Keywords: dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•