Closed
Bug 398556
Opened 17 years ago
Closed 17 years ago
forward and reply of .eml stopped working on trunk
Categories
(Thunderbird :: Message Compose Window, defect)
Thunderbird
Message Compose Window
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3
People
(Reporter: mkmelin, Assigned: mkmelin)
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
patch
|
philor
:
review+
|
Details | Diff | Splinter Review |
If you open an .eml from disk you can't forward or reply to it. A var definition was forgot in bug 320102.
Error: server is not defined
Source File: chrome://messenger/content/mailCommands.js
Line: 150
The patch fixes that (and cleans up some whitespace).
Attachment #283546 -
Flags: review?(philringnalda)
|
Assignee | |
Updated•17 years ago
|
Summary: forward and reply of .eml doesn't stopped working on trunk → forward and reply of .eml stopped working on trunk
|
||
Comment 1•17 years ago
|
||
Comment on attachment 283546 [details] [diff] [review]
proposed fix
Such a lot of uncommented assumptions about the state of the world, for such a small function :)
r=me as long as you're reasonably sure the callers' callers aren't depending on that accidental global pollution (though if they are, they deserve a good breaking)
Attachment #283546 -
Flags: review?(philringnalda) → review+
|
|
Assignee | |
Comment 2•17 years ago
|
||
Checking in mail/base/content/mailCommands.js;
/cvsroot/mozilla/mail/base/content/mailCommands.js,v <-- mailCommands.js
new revision: 1.36; previous revision: 1.35
done
->FIXED
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•