Closed
Bug 398571
Opened 17 years ago
Closed 17 years ago
PRBool misuse bugs in accessible/
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: taras.mozilla, Assigned: taras.mozilla)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
Errors reported by prcheck
Attachment #283576 -
Flags: review?(aaronleventhal)
|
Assignee | |
Updated•17 years ago
|
Status: NEW → ASSIGNED
|
||
Updated•17 years ago
|
Attachment #283576 -
Flags: review?(aaronleventhal) → review+
|
|
Assignee | |
Updated•17 years ago
|
Attachment #283576 -
Flags: approval1.9?
|
||
Comment 1•17 years ago
|
||
You replace the expression
PRBool isEnabled = state & nsIAccessibleStates::STATE_CHECKED;
on the
PRBool isEnabled = 0 != (state & nsIAccessibleStates::STATE_CHECKED);
The second expression looks a bit complex than the first one. Why do we need this? Afaik it doesn't lead to compilation warnings.
|
|
Assignee | |
Comment 2•17 years ago
|
||
See bug 266048. PRBool are to only contain 0/1.
|
|
||
Comment 3•17 years ago
|
||
ok, thanks. a kind of complex assurance :)
|
||
Updated•17 years ago
|
Attachment #283576 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Comment 4•17 years ago
|
||
Using !! instead of 0 !=
Attachment #283576 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•17 years ago
|
||
Checking in accessible/src/base/nsRootAccessible.cpp;
/cvsroot/mozilla/accessible/src/base/nsRootAccessible.cpp,v <-- nsRootAccessible.cpp
new revision: 1.235; previous revision: 1.234
done
Checking in accessible/src/atk/nsAppRootAccessible.cpp;
/cvsroot/mozilla/accessible/src/atk/nsAppRootAccessible.cpp,v <-- nsAppRootAccessible.cpp
new revision: 1.39; previous revision: 1.38
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•