Closed
Bug 399196
Opened 17 years ago
Closed 17 years ago
page info is too small with a new profile
Categories
(Firefox :: Page Info Window, defect)
Firefox
Page Info Window
Tracking
()
VERIFIED
FIXED
Firefox 3 beta1
People
(Reporter: Peter6, Assigned: florian)
References
Details
(Keywords: regression)
Attachments
(2 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
patch
|
Gavin
:
review+
mconnor
:
approval1.9+
|
Details | Diff | Splinter Review |
screenshots
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007100907 Minefield/3.0a9pre ID:2007100907
repro1:
open FF with a used profile
open any page and get Page Info
result:
looks normal
repro2:
create a new profile and open FF
open any page and get Page Info
result:
it's not high enough
the PageInfo window size is not remembered after changing it , i'm not sure if that's intended or not.
|
||
Comment 1•17 years ago
|
||
That's strange: http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/base/content/pageinfo/pageInfo.xul&rev=1.9&mark=65,66#65 shows that we still try to persist height/width, and still set a height that's greater than the one shown in your screenshot.
|
|
||
Comment 2•17 years ago
|
||
This seems to have regressed in the past 10 days or so, my build from the 2nd doesn't seem to have this bug.
|
||
Comment 3•17 years ago
|
||
Confirmed with Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9a9pre)
Gecko/2007101404 Minefield/3.0a9pre (even worse on the list)
OS: Windows XP → All
|
||
Updated•17 years ago
|
|
|
||
Comment 4•17 years ago
|
||
|
|
||
Updated•17 years ago
|
Flags: blocking-firefox3?
|
Assignee | |
Comment 5•17 years ago
|
||
This bug seems to be only a typo.
|
|
||
Updated•17 years ago
|
Flags: blocking-firefox3?
|
|
||
Comment 6•17 years ago
|
||
Comment on attachment 284917 [details] [diff] [review]
patch
Gah!
Attachment #284917 -
Flags: review?(mano) → review+
|
|
||
Updated•17 years ago
|
Attachment #284917 -
Flags: approval1.9?
|
||
Updated•17 years ago
|
Attachment #284917 -
Flags: approval1.9? → approval1.9+
|
|
||
Updated•17 years ago
|
Keywords: checkin-needed
|
|
||
Updated•17 years ago
|
Target Milestone: --- → Firefox 3 M9
|
||
Comment 7•17 years ago
|
||
Checking in browser/base/content/pageinfo/pageInfo.xul;
/cvsroot/mozilla/browser/base/content/pageinfo/pageInfo.xul,v <-- pageInfo.xul
new revision: 1.10; previous revision: 1.9
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Hardware: PC → All
Resolution: --- → FIXED
|
|
||
Comment 8•17 years ago
|
||
Verified with Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9a9pre) Gecko/2007101904 Minefield/3.0a9pre
|
||
Updated•17 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•