As soon as the SeaMonkey port of bug 74959 gets in, we need new icons for "Go back" and "Go forward", for both Classic and Modern. (The patch over there just recycles some vaguely adequate icons.)

New mailnews icons for GoBack/GoForward toolbarbuttons based off of the Mark message toolbarbutton, which seemed more fitting since they more resemble the 16bit thread images in the threadpane. The new buttons were added at the bottom and below are the messenger/primaryToolbar.css stylesheet changes needed: #button-goback { -moz-image-region: rect(578px 49px 611px 0px); } #button-goback:hover { -moz-image-region: rect(578px 99px 611px 50px); } #button-goback:hover:active { -moz-image-region: rect(578px 149px 611px 100px); } #button-goback[disabled] { -moz-image-region: rect(578px 199px 611px 150px) !important; } #button-goforward { -moz-image-region: rect(612px 49px 645px 0px); } #button-goforward:hover { -moz-image-region: rect(612px 99px 645px 50px); } #button-goforward:hover:active { -moz-image-region: rect(612px 149px 645px 100px); } #button-goforward[disabled] { -moz-image-region: rect(612px 199px 645px 150px) !important; }

Is it just me or are the edges somewhat ragged? And I think KaiRo mentioned something about needing the icons in SVG (or some other easily accessible vector format) for reference purposes.

- Made lines on images appear more parallel - Better aligns new icons with themselves and other similar icons, e.g., Mark Messages

Re. comment #2 I can provide them as separate PSD bitmap files but not in vector form since I used the Mark Messages bitmap images as the source and bit-hacked them to derive at destination versions. Also, while the latest version (comment #3) has added improvements with the inside lines of the icons, the edges should be extremely close to what exists in the Mark Message icon, I think?

Added missing arrow shadows to new icons.

Comment on attachment 313679 [details] Updated Image Map I'm going to pick some seamonkey people at random for review and super-review, Karsten as the MailNews module owner, and Neil as the SeaMonkey module owner. Please reassign if you think that there are more suitable reviewers.

Your assignments are fine from my POV. Notes: 1. I noticed that I was 1 pixel off on the arrow alignment for the GoForward normal state and will upload a fixed revision once I hear back that the icons are acceptable. 2. The bug covers the new Classic icons as well; however, I do not plan on crafting those since I suspect that the theme designer has plans on those.

Comment on attachment 313679 [details] Updated Image Map Looks fine by me. Can you do the CSS diff, too, or do you need help with that?

Ref: comment #9 The only experience I have with CVS is using WinCVS on mozdev a few years ago, so while I'm familiar with it, I wouldn't trust myself on how to create a CSS diff with SeaMonkey source. Is there a simple windows tool out there where I can give it a current and new pathname and it will produce an acceptable diff?

> Can you do the CSS diff, too, or do you need help with that? Err, since when is a cvs diff needed for binary files ???

I believe Karsten is referring the CSS stylesheet changes to the messenger/primaryToolbar.css file in included in comment #1.

If you already have WinCVS installed and if you've checked out the /suite/themes/modern/ directory in WinCVS, and edited the messenger/primaryToolbar.css file; then, Make sure that the "mozilla" folder is hightlighted in the folder pane on the left. Basically you need to be high enough in the tree to generate a diff that the patch.exe utility can use to find the correct directory/files to patch. On the right file list pane, right click on the primaryToolbar.css file and select the "Diff" menu option. Tick off the "Unified diff" box and in the "Other Options" text box add "-8". For files containing source code (js or C++) you might want to use "-8p". Cut and paste the output in the console/output pane into a text file. Otherwise any CVS command line client should accept the |cvs diff -foo -bar| command.

Philip, it may be better to take this offline rather than spam the bug? While I have WinCVS, I only used it with updating some pages on themes.mozdev.org. I use WinDiff to work on my themes locally and even there, mostly to just find the theme file changes from one release to another.

Rather than spending too much time re-teaching an old dog the same trick, I've attached the entire modified messenger/primaryToolbar.css file in the event that someone may find it easier to use it and create the diff themselves. Otherwise, I'm more than willing to be re-taught if someone is willing to remote re-teach.

> Rather than spending too much time re-teaching an old dog the same trick, I've > attached the entire modified messenger/primaryToolbar.css file in the event > that someone may find it easier to use it and create the diff themselves. Here's a patch in diff -u8 format.

Comment on attachment 314783 [details] [diff] [review] Patch for suite/themes/modern/messenger/primaryToolbar.css Thanks to both of you. Oddly file style seems to be to use 0 instead of 0px.

Most of the -moz-image-region styles used in the standard themes seem to use a unitless 0 rather than explicitly using a px unit declaration. Per w3c rules, it's okay to exclude a unit declaration on any dimension item when its value is zero. I tend to not prefer reliance on this method and so my changes included the px value.

Stylistic nit: The mozilla.org rule is to follow the prevailing style of the file unless there are overriding reasons not to (note I'm not saying that you are wrong here).

I understand and would completely understand if you wanted to maintain the theme's consistency and revert the 0px values back to unitless zeros.

FYI: I don't have any authority here. Neil is the final arbiter for SeaMonkey.

Comment on attachment 314783 [details] [diff] [review] Patch for suite/themes/modern/messenger/primaryToolbar.css r=me if you use plain 0 values instead of 0px.

Comment on attachment 313872 [details] /suite/themes/modern/messenger/icons/btn1.gif Corrects GoBack arrow's misalignment Carrying forward r+/sr+ mnyromyr: review+ neil: superreview+

(In reply to comment 24) > (From update of attachment 314783 [details] [diff] [review]) > r=me if you use plain 0 values instead of 0px. Stylistic nits fixed. Carrying forward r+/sr+ mnyromyr: review+ neil: superreview+

I checked in attachment 313872 [details] and attachment 316151 [details] [diff] [review]. mozilla/suite/themes/modern/messenger/primaryToolbar.css 1.21 mozilla/suite/themes/modern/messenger/icons/btn1.gif 1.4

still need this open?

> still need this open? Probably not. This landed somewhere between 1.1.9 and 1.1.10. I'll just pick something vaguely around that time for the target milestone. Someone in SeaMonkey team could possibly save the .PSD file in Comment 10 to somewhere more discoverable in case we need to do more tweaks.

(In reply to Philip Chee from comment #29) > This landed somewhere between 1.1.9 and 1.1.10. I'll just pick something > vaguely around that time for the target milestone. ^_^ > Someone in SeaMonkey team could possibly save the .PSD file in Comment 10 to > somewhere more discoverable in case we need to do more tweaks. Wouldn't know where …