Jesse Ruderman Reporter
	Description • 17 years ago

Loading the testcase triggers:

###!!! ASSERTION: next in flow should have been deleted: '!kidNextInFlow', file /Users/jruderman/trunk/mozilla/layout/generic/nsColumnSetFrame.cpp, line 549

Reloading it triggers:

###!!! ASSERTION: Some objects allocated with AllocateFrame were not freed: 'mFrameCount == 0', file /Users/jruderman/trunk/mozilla/layout/base/nsPresShell.cpp, line 673

	fantasai Assignee
	Comment 1 • 17 years ago

WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x8000FFFF: file /home/fantasai/moz/mozilla/layout/generic/nsBlockFrame.cpp, line 3056
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x8000FFFF: file /home/fantasai/moz/mozilla/layout/generic/nsBlockFrame.cpp, line 1855
###!!! ASSERTION: reflow dirty lines failed: 'NS_SUCCEEDED(rv)', file /home/fantasai/moz/mozilla/layout/generic/nsBlockFrame.cpp, line 941
###!!! ASSERTION: next in flow should have been deleted: '!kidNextInFlow', file /home/fantasai/moz/mozilla/layout/generic/nsColumnSetFrame.cpp, line 549
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x8000FFFF: file /home/fantasai/moz/mozilla/layout/generic/nsBlockFrame.cpp, line 3056
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x8000FFFF: file /home/fantasai/moz/mozilla/layout/generic/nsBlockFrame.cpp, line 1855
###!!! ASSERTION: reflow dirty lines failed: 'NS_SUCCEEDED(rv)', file /home/fantasai/moz/mozilla/layout/generic/nsBlockFrame.cpp, line 941
###!!! ASSERTION: next in flow should have been deleted: '!kidNextInFlow', file /home/fantasai/moz/mozilla/layout/generic/nsColumnSetFrame.cpp, line 549

ReflowChild doesn't delete the next-in-flows if it gets a failure from Reflow. (Also nsColumnSetFrame::ReflowChildren isn't checking the nsresult returned by ReflowChild.)

roc, should ReflowChild be deleting the orphaned nifs?

	Robert O'Callahan (:roc) (email my personal email if necessary)
	Comment 2 • 17 years ago

Probably, although I'm not really sure what the invariants surrounding failed Reflow are.

But Reflow really shouldn't be failing in the first place...

	fantasai Assignee
	Comment 3 • 17 years ago

Yeah, that, too. This seems to fix that problem. Was getting some really *weird* frame trees when the balancing code tried to balance with the overflow containers.

	Mike Beltzner [:beltzner, not reading bugmail]
	Comment 4 • 17 years ago

Comment on attachment 285195 [details] [diff] [review]
patch to fix layout

a=drivers for after M9 freeze

	Reed Loden [:reed]
	Comment 5 • 17 years ago

fantasai said she can check-in herself.

	fantasai Assignee
	Comment 6 • 17 years ago

Fix checked in: nsColumnSetFrame.cpp rev 3.44

	Jesse Ruderman Reporter
	Comment 7 • 17 years ago

The testcase doesn't trigger any assertions on branch.

	Jesse Ruderman Reporter
	Comment 8 • 17 years ago

Crashtest checked in.