Closed
Bug 399418
Opened 17 years ago
Closed 17 years ago
bug #387996 caused refcount leaks (RLk) to go from 8 B to 500 B on Linux fxdbug-linux-tbox Dep
Categories
(Firefox :: Bookmarks & History, defect)
Tracking
()
RESOLVED
FIXED
Firefox 3 beta1
People
(Reporter: moco, Assigned: asaf)
References
()
Details
(Keywords: memory-leak, regression)
bug #387996 caused refcount leaks to go from 8 B to 500 B on Linux fxdbug-linux-tbox Dep
--NEW-LEAKS-----------------------------------leaks------leaks%-----------------------
nsNavHistoryQueryOptions 68 -
nsNavHistoryContainerResultNode 140 -
nsNavHistoryFolderResultNode 148 -
nsVoidArray 4 -
nsNavHistoryResultNode 100 -
nsStringBuffer 40 400.00%
note, the RLk numbers on MacOSX Darwin 8.8.4 bm-xserve11 Dep Debug + Leak Test did not change.
I'll investigate.
Updated•17 years ago
|
Flags: blocking-firefox3?
Keywords: mlk,
regression
Updated•17 years ago
|
Flags: blocking-firefox3? → blocking-firefox3+
Reporter | ||
Comment 1•17 years ago
|
||
I've disabled the feature in bug #387996 by setting the default pref to be true in
browser/app/profile/firefox.js:
+// disable adding the "Places" folder with pre-defined queries
+pref("browser.places.createdDefaultQueries", true);
RLk is back to 8 B.
Now to figure out the leaks so that the feature can be re-enabled.
Assignee: nobody → sspitzer
Updated•17 years ago
|
Summary: bug #387996 caused refcount leaks to go from 8 B to 500 B on Linux fxdbug-linux-tbox Dep → bug #387996 caused refcount leaks (RLk) to go from 8 B to 500 B on Linux fxdbug-linux-tbox Dep
Reporter | ||
Comment 2•17 years ago
|
||
note, after mano's patch for bug #399476, I no longer see these leaks (even if I open up bookmark menus and folders from the personal toolbar.)
over to mano, for credit.
but, mano and I both think we still have leaks lurking.
I do see that we leak several nsNavHistoryResultNodes when we reload live bookmarks, but I'll spin that off to another bug.
Assignee: sspitzer → mano
Depends on: 399476
Reporter | ||
Comment 3•17 years ago
|
||
marking fixed on mano's behalf. after re-enabling the pref, there was no change in RLk.
> I do see that we leak several nsNavHistoryResultNodes when we reload live
> bookmarks, but I'll spin that off to another bug.
logged bug #399673
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M9
Comment 4•15 years ago
|
||
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".
In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body contains places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.
Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.
Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•