Closed
Bug 400924
Opened 17 years ago
Closed 17 years ago
star / bookmark dialog: click to close
Categories
(Firefox :: Bookmarks & History, defect, P2)
Tracking
()
VERIFIED
FIXED
Firefox 3 beta1
People
(Reporter: moco, Assigned: asaf)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
moco
:
review+
mconnor
:
approvalM9+
|
Details | Diff | Splinter Review |
star dialog: click to close
on windows xp, clicking on the star button (that you clicked on to bookmark a page) doesn't close it.
clicking elsewhere does close it.
note, this is not an issue on mac.
this is very much like "Larry UI: click to close" bug that johnath fixed today.
see bug #395314 for his solution.
Just as that bug was a blocker, I think we should block on this one, too.
Flags: blocking-firefox3?
|
Reporter | |
Updated•17 years ago
|
Summary: star dialog: click to close → star / bookmark dialog: click to close
|
||
Updated•17 years ago
|
Assignee: nobody → mano
Flags: blocking-firefox3? → blocking-firefox3+
|
Assignee | |
Comment 1•17 years ago
|
||
Attachment #286773 -
Flags: review?(sspitzer)
|
|
Assignee | |
Updated•17 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P2
|
|
Reporter | |
Comment 2•17 years ago
|
||
Comment on attachment 286773 [details] [diff] [review]
patch
r=sspitzer
mano, king of memoization!
Attachment #286773 -
Flags: review?(sspitzer) → review+
|
|
Assignee | |
Updated•17 years ago
|
Attachment #286773 -
Flags: approvalM9?
|
|
Reporter | |
Comment 3•17 years ago
|
||
Comment on attachment 286773 [details] [diff] [review]
patch
while testing, found that this didn't work.
but mano has a version that does.
Attachment #286773 -
Flags: review+
Attachment #286773 -
Flags: approvalM9?
|
|
Assignee | |
Comment 4•17 years ago
|
||
Attachment #286773 -
Attachment is obsolete: true
Attachment #286776 -
Flags: review?(sspitzer)
Attachment #286776 -
Flags: approvalM9?
|
|
Assignee | |
Updated•17 years ago
|
Attachment #286776 -
Attachment is patch: true
Attachment #286776 -
Attachment mime type: application/octet-stream → text/plain
|
|
Reporter | |
Comment 5•17 years ago
|
||
Comment on attachment 286776 [details] [diff] [review]
v2
r=sspitzer (tested it on windows xp)
Attachment #286776 -
Flags: review?(sspitzer) → review+
|
|
||
Updated•17 years ago
|
Attachment #286776 -
Flags: approvalM9? → approvalM9+
|
|
Assignee | |
Comment 6•17 years ago
|
||
mozilla/browser/base/content/browser-places.js 1.58
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M9
|
||
Comment 7•17 years ago
|
||
verified fixed using Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9a9pre) Gecko/2007110103 Minefield/3.0a9pre and the steps to reproduce from seth in comment #0
-> verified
Status: RESOLVED → VERIFIED
|
||
Comment 8•15 years ago
|
||
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".
In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body contains places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.
Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.
Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•