Dão Gottwald [:dao] Assignee
	Description • 17 years ago

see bug 389628 comment 135

	Asaf Romano (gone)
	Comment 1 • 17 years ago

Comment on attachment 286273 [details] [diff] [review]
patch

I think it'd better rev the entities to ...zooom/In/Out.. as well.

r=mano either way.

	Dão Gottwald [:dao] Assignee
	Comment 2 • 17 years ago

Comment on attachment 286273 [details] [diff] [review]
patch

(In reply to comment #1)
Hrm, yes, might be a little bit clearer ... but it would also mean to change more similar entities and the code that's using them.

	Rimas Kudelis [use needinfo to ping]
	Comment 3 • 17 years ago

I think the policy is you shouldn't change the meaning of an entity without changing its name, so that the localizers know what to review.

Would it be hard to change all those similar entities?

	Vlado Valastiak [:wladow]
	Comment 4 • 17 years ago

If this will be commited ASAP, I think entity name change isn't needed. According to buildbot, only our (sk) locale was updated after landing bug 389628 and we will fix this in our locale today.

	Dão Gottwald [:dao] Assignee
	Comment 5 • 17 years ago

(In reply to comment #3)
> I think the policy is you shouldn't change the meaning of an entity without
> changing its name, so that the localizers know what to review.

Note that the meaning of the entities remains the same, I'm fixing a bug in the en-US strings.

> Would it be hard to change all those similar entities?

It wouldn't be precisely hard, but a relatively much bigger patch, with the (low) risk of new regressions.

	Mike Beltzner [:beltzner, not reading bugmail]
	Comment 6 • 17 years ago

Comment on attachment 286273 [details] [diff] [review]
patch

a=beltzner for M9

	Reed Loden [:reed]
	Comment 7 • 17 years ago

Checking in toolkit/locales/en-US/chrome/mozapps/help/help.dtd;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/mozapps/help/help.dtd,v  <--  help.dtd
new revision: 1.9; previous revision: 1.8
done

If somebody can help make sure some locale doesn't get confused by this, we'd really appreciate it. Thanks!

	Stephen Donner [:stephend] Not actively reading bugmail
	Comment 8 • 17 years ago

Verified FIXED via code inspection, using MXR to poke Bonsai (http://bonsai.mozilla.org/cvslog.cgi?file=/mozilla/toolkit/locales/en-US/chrome/mozapps/help/help.dtd&rev=HEAD&mark=1.9):

1.9	reed%reedloden.com	2007-10-26 06:47	 	Bug 401220 - ""Zoom In" and "Zoom Out" are interchanged in help.dtd" [p=dao r=Mano aM9=beltzner]