Hussam Al-Tayeb Reporter
	Description • 17 years ago

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a9pre) Gecko/2007102612 Firefox/3.0a9pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a9pre) Gecko/2007102612 Firefox/3.0a9pre

This isn't a bug but rather a enhancement request. We already use the stock system gnome icons in the beautified ftp:// interface.
Check ftp://ftp.somesite.org or file:///home under gnome and you will see the stock gnome icons. This means the we have the infrastructure backend to use those icons.
The current folder icons in the bookmarks menu looks too much like windowsXP style icons.
If we can use the system icons under gnome (Linux), this would slightly increase the usability and aesthetics of Firefox under Linux.

Thanks you in advance for considering my enhancement request.

Reproducible: Always

	Teune van Steeg
	Comment 1 • 17 years ago

This is what my userChrome.css looks like to have all folder icons use stock icons

	Hussam Al-Tayeb Reporter
	Comment 3 • 17 years ago

(In reply to comment #2)
> Created an attachment (id=289567) [details]
> Patch
> 

Patch works correctly in my builds. I have a comment though. It uses the same icon for closed and expanded folders. Does gnome icon theme provide expanded folder icons?

	Hussam Al-Tayeb Reporter
	Comment 4 • 17 years ago

Patch needs to be reworked to apply to latest cvs. It doesn't apply anymore after bug 404475.

	Michael Ventnor Assignee
	Comment 5 • 17 years ago

(In reply to comment #3)
> (In reply to comment #2)
> > Created an attachment (id=289567) [details] [details]
> > Patch
> > 
> 
> Patch works correctly in my builds. I have a comment though. It uses the same
> icon for closed and expanded folders. Does gnome icon theme provide expanded
> folder icons?

It does but we can't use it because GTK doesn't provide access to it. Limiting our use of stock icons to GTK's API ensures that every icon is available on any theme.

	Hussam Al-Tayeb Reporter
	Comment 7 • 17 years ago

patch 2 is working fine.
There's still the back/forward/home/print buttons in the help viewer. Is there a open bug for that?

	Michael Monreal [:micmon]
	Comment 8 • 17 years ago

Hussam: see bug 404530 for a very complete list of places were we plan to use GTK stock icons. There's also bug 405165, which is about adding (mostly stock) icons to the menus.

Michael: We (the tango project) have experimented with various styles for the personal bookmarks toolbar and agreed to not use folder icons for the containers here, but rather do it similar to OSX and the GNOME webbrowser:

# skip the image
# add a dropmarker on the right (hopefully a native GTK drop-arrow as seen in the list header)
# transform the menu into a gtk button

We also would like not to show the placeholder (white sheet) for bookmarks that don't have a favicon, as we feel that those just clutter the interface.

I'll attach a CSS with out current changes. Feel free to patch something like this in for this bug, but I can also file a separate bug.

	Michael Monreal [:micmon]
	Comment 10 • 17 years ago

Sorry, that should have been .css instead of .cs

	Takeshi Kurosawa :takenspc
	Comment 11 • 17 years ago

Comment on attachment 290087 [details]
Personal toolbar/Bookmark changes

changed the filename: unclutter.cs -> unclutter.css

	Michael Ventnor Assignee
	Comment 12 • 17 years ago

Can you do the review anytime soon, Ryan?

	Ryan Flint [:rflint] (ping via IRC for reviews)
	Comment 13 • 17 years ago

mozilla/browser/themes/gnomestripe/browser/browser.css 	1.138
mozilla/browser/themes/gnomestripe/browser/places/organizer.css 	1.2
mozilla/browser/themes/gnomestripe/browser/places/places.css 	1.21 

a=mconnor as part of gnomestripe.

	Wolfgang Rosenauer [:wolfiR]
	Comment 14 • 17 years ago

Does that still work with 3.0b4 or trunk?
I've got the following report:
https://bugzilla.novell.com/show_bug.cgi?id=373173
which suggests that the folder icon is not taken from the Gtk theme.