Closed
Bug 401826
Opened 17 years ago
Closed 9 years ago
Support for gnomevfs write functionality
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: dougt, Unassigned)
References
Details
Reporter | ||
Comment 1•17 years ago
|
||
Reporter | ||
Comment 2•17 years ago
|
||
https://garage.maemo.org/svn/browser/mozilla/trunk/microb-engine/microb-engine/debian/patches/345_BUG382486_EngineOutputProtocolSupport.diff
+ // FIXME Hack to fix a crash
pleasant isn't it...
nsWebBrowserPersist::MakeOutputStreamFromURI(
nsIURI *aURI, nsIOutputStream **aOutputStream)
{
PRUint32 segsize = 8192;
PRUint32 maxsize = PRUint32(-1);
+ nsresult rv;
+ rv = NS_NewOutputStream(aOutputStream, aURI);
+ if (NS_SUCCEEDED(rv))
+ return rv;
+
nsCOMPtr<nsIStorageStream> storStream;
- nsresult rv = NS_NewStorageStream(segsize, maxsize, getter_AddRefs(storStream));
+ rv = NS_NewStorageStream(segsize, maxsize, getter_AddRefs(storStream));
NS_ENSURE_SUCCESS(rv, rv);
when this check fails, aOutputStream should leak (because by definition out values are only valid for SUCCESS codes, and the caller should not touch them otherwise).
https://garage.maemo.org/svn/browser/mozilla/trunk/microb-engine/microb-engine/debian/patches/395_gnomevfs_downloads.diff
nsresult nsExternalAppHandler::ExecuteDesiredAction()
{
nsresult rv = NS_OK;
if (mProgressListenerInitialized && !mCanceled)
{
+ if(mFinalFileDestination)
this isn't following convention (it's missing the space after if).
rv = PromptForSaveToFile(getter_AddRefs(fileToUse), leafName, mTempFileExtension);
+ if(NS_FAILED(rv))
+ rv = PromptForSaveToUri(getter_AddRefs(uriToUse), leafName, mTempFileExtension);
this pattern is very strange.
https://garage.maemo.org/svn/browser/mozilla/trunk/microb-engine/microb-engine/debian/patches/670_obex_error_handling.diff
is strange
the proper "fix" is bug 382486.
OS: Mac OS X → Linux
Hardware: PC → All
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•