Closed Bug 402286 Opened 17 years ago Closed 17 years ago

Remove applet tags support from Page Info

Categories

(Firefox :: Page Info Window, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3 beta2

People

(Reporter: florian, Assigned: florian)

References

Details

Attachments

(2 files)

Java applet support from the Page Info Media tab is broken. Currently it's disabled when Java is enabled because it historically caused crashes. In the Media tab we have a list of URLs, each one standing for a media element of the page. Java applets don't fit with this because a single applet can use several files. The solution that the code currently uses to get one URL for the applet is completely wrong (see bug 400485). If we want to fix this we should probably implement the algorithm given in bug 400485 comment 21 to get a list of the files used by the applet. In this case we would display a list item in the Media tab for each file. Or maybe we can simply drop applet tags support from Page Info. It's been nearly completely broken for a long time and nobody complained so I bet very few people would miss it. I prefer this later solution. Other ideas welcomed of course
Flags: blocking-firefox3?
Doesn't block Firefox 3, as it's not really a regression. Is it possible to fake this out so that a single entry represents the Java applet? What's the goal of showing it in Page Info - to provide a place to download the applet files, or just illustrating the presence of the applet? I agree that if we can't get it right, we should remove it instead of lying about it ;)
Flags: blocking-firefox3? → blocking-firefox3-
(In reply to comment #1) > Is it possible to fake this out so that a single entry represents the Java > applet? That's what we are currently doing. But we display only a single url and this url is wrong. It would not be easy with the current implementation to have multiple urls for a single media entry. > What's the goal of showing it in Page Info - to provide a place to > download the applet files, or just illustrating the presence of the applet? > I'm not sure, but I would say both. > I agree that if we can't get it right, we should remove it instead of lying > about it ;) > I think right now we can't get it right.
Assignee: nobody → f.qu
Attached patch patch v1 (deleted) — Splinter Review
Remove applet support.
Attachment #288090 - Flags: review?(mano)
Comment on attachment 288090 [details] [diff] [review] patch v1 r=mano
Attachment #288090 - Flags: review?(mano) → review+
Attachment #288090 - Flags: approval1.9?
Attachment #288090 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in browser/base/content/pageinfo/pageInfo.js; /cvsroot/mozilla/browser/base/content/pageinfo/pageInfo.js,v <-- pageInfo.js new revision: 1.10; previous revision: 1.9 done Checking in browser/locales/en-US/chrome/browser/pageInfo.properties; /cvsroot/mozilla/browser/locales/en-US/chrome/browser/pageInfo.properties,v <-- pageInfo.properties new revision: 1.12; previous revision: 1.11 done
Status: NEW → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Summary: Fix or remove applet tags support from Page Info → Remove applet tags support from Page Info
Target Milestone: --- → Firefox 3 M10
No longer depends on: 403724
Depends on: 403724
Attached patch seamonkey port (deleted) — Splinter Review
Attachment #293246 - Flags: superreview?
Attachment #293246 - Flags: review?(db48x)
Attachment #293246 - Flags: superreview? → superreview?(neil)
Comment on attachment 293246 [details] [diff] [review] seamonkey port r=db48x
Attachment #293246 - Flags: review?(db48x) → review+
So how does the page info for an <object> with a Java type differ from the info for an <applet> which presumably appears the same on screen?
(In reply to comment #8) > info for an <object> with a Java type I guess it's not displayed at all now. On <object> tags Page Info only tries to find an url in the "data" property which is apparently not used by java applets. > the info for an <applet> It's listed as "Applet" in the Media tab, but the url we get for it is bogus and that's why we removed it from Page Info/Firefox in this bug.
Attachment #293246 - Flags: superreview?(neil) → superreview+
Fixed in SeaMonkey too. Checking in suite/browser/pageinfo/pageInfo.js; /cvsroot/mozilla/suite/browser/pageinfo/pageInfo.js,v <-- pageInfo.js new revision: 1.5; previous revision: 1.4 done Checking in suite/locales/en-US/chrome/browser/pageInfo.properties; /cvsroot/mozilla/suite/locales/en-US/chrome/browser/pageInfo.properties,v <-- pageInfo.properties new revision: 1.21; previous revision: 1.20 done
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: