Regressed between [Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a9pre) Gecko/2007103103 Minefield/3.0a9pre] (nightly) (W2Ksp4) and [Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a9pre) Gecko/2007110103 Minefield/3.0a9pre] (nightly) (W2Ksp4) Confirmed by [Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a9pre) Gecko/2007103102 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4) and [Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a9pre) Gecko/2007110103 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4) My steps: 1. Start browser application. 2. Load <about:>. 3. Copy the build id "line". 4. Paste it in another app: works :-) 5. Exit browser application. 6. Paste it in another app: no more data :-( <http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=MozillaTinderboxAll&branch=HEAD&branchtype=match&sortby=Date&hours=2&date=explicit&mindate=2007-10-31+03&maxdate=2007-11-01+04+&cvsroot=%2Fcvsroot> My best guess would be bug 386286.

Blocking, but not blocking beta. Adding relnote ...

Taking.

This should fix it. The problem was that OleUninitialize was called before the observer in nsClipboard tried to call OleFlushClipboard. I removed the observed and moved OleFlushClipboard right before OleUninitialize. The comment changes are just removed CR's.

And the CloseClipboard call in nsClipboard was superfluous.

(Had a look at MSDN for both functions: the fix looks perfect ;-))

Comment on attachment 287856 [details] [diff] [review] Patch >+NS_IMPL_ISUPPORTS1(nsClipboard, nsBaseClipboard) >+ NS_DECL_ISUPPORTS You shouldn't need these, nsBaseClipboard already provides them. (They were there before to resolve the ambiguous nsISupports cast.)

Comment on attachment 287856 [details] [diff] [review] Patch Ok, I'll remove them before checking in.

Ere, jst-review takes exception to your patch as well. http://beaufour.dk/jst-review/

(In reply to comment #8) >Ere, jst-review takes exception to your patch as well. >http://beaufour.dk/jst-review/ That's a bug in jst-review, not in the patch.

Not the complaint about Windows line endings...

?? The patch _removes_ a couple of Windows line endigns and I can't see jst-review complaining about that.

OK, nevermind me then :). Sorry for the spam.

Ere, think you could commit this soon? If you don't have time, just let me know, and I can check it in for you.

Fix checked in.

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b2pre) Gecko/2007111403 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4) V.Fixed.

FYI, this bug isn't listed in Beta 1 rel notes yet: http://www.mozilla.com/en-US/firefox/3.0b1/releasenotes/

(In reply to comment #17) > FYI, this bug isn't listed in Beta 1 rel notes yet: > http://www.mozilla.com/en-US/firefox/3.0b1/releasenotes/ Is there still a reason to relnote something as this is fixed?

This may be a fixed bug but I see it every day.

(In reply to comment #19) > This may be a fixed bug but I see it every day. This bug was (reported) fixed 2 years ago. Please file a new bug, with details.