Closed
Bug 402853
Opened 17 years ago
Closed 17 years ago
linker warnings for libxul
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9beta2
People
(Reporter: nthomas, Assigned: benjamin)
References
Details
Attachments
(2 files)
(deleted),
text/plain
|
Details | |
(deleted),
patch
|
ted
:
review+
damons
:
approval1.9+
|
Details | Diff | Splinter Review |
Saw these in the 3.0b1 build, and bug 388663 comment #14 indicates when it started.
Reporter | ||
Comment 1•17 years ago
|
||
Comment 2•17 years ago
|
||
I remember asking in IRC about them back in the day and was told that they're not a concern, FWIW. They are certainly an irritant, though.
Reporter | ||
Updated•17 years ago
|
Summary: compiler warnings linking libxul → linker warnings for libxul
Assignee | ||
Comment 3•17 years ago
|
||
This is a well-educated but completely untried guess. Maybe I should ask the tryserver.
Assignee: nobody → benjamin
Status: NEW → ASSIGNED
Attachment #287708 -
Flags: review?(ted.mielczarek)
Assignee | ||
Comment 4•17 years ago
|
||
FWIW, this was green on the tryserver and there were no warnings.
Updated•17 years ago
|
Attachment #287708 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Updated•17 years ago
|
Attachment #287708 -
Flags: approval1.9?
Comment 5•17 years ago
|
||
Comment on attachment 287708 [details] [diff] [review]
Guess, rev. 1
a=release drivers
Attachment #287708 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Comment 6•17 years ago
|
||
Fixed on trunk
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Comment 7•17 years ago
|
||
Backed out in an attempt to fix orange.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 8•17 years ago
|
||
This caused red later in the day when smaug and I checked in changes to layout. I guess it needed at least an objdir clobber.
This is also one of the two bugs (along with bug 402198) still suspected of causing the prolonged orange on the Windows unit test boxes over the weekend (bug 403271 comment 7). That orange could only be fixed by doing a srcdir clobber, so please reland this at a time when robcee is around (coordinate using #developers).
Comment 9•17 years ago
|
||
relanded.
Checking in config/config.mk;
/cvsroot/mozilla/config/config.mk,v <-- config.mk
new revision: 3.380; previous revision: 3.379
done
Status: REOPENED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M10
Depends on: 403724
You need to log in
before you can comment on or make changes to this bug.
Description
•