Closed
Bug 403134
Opened 17 years ago
Closed 17 years ago
[FIX]"ASSERTION: Weird break found!" with -moz-column
Categories
(Core :: Graphics, defect, P3)
Tracking
()
VERIFIED
FIXED
mozilla1.9beta2
People
(Reporter: jruderman, Assigned: bzbarsky)
References
Details
(Keywords: assertion, hang, testcase)
Attachments
(2 files)
|
(deleted),
text/html
|
Details | |
|
(deleted),
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
Loading the testcase triggers
###!!! ASSERTION: Weird break found!: 'limitLength >= 0', file /Users/jruderman/trunk/mozilla/layout/generic/nsTextFrameThebes.cpp, line 5248
and content duplication.
I think this can cause hangs, too.
Flags: blocking1.9?
Flags: blocking1.9? → blocking1.9+
Priority: -- → P3
|
Assignee | |
Comment 1•17 years ago
|
||
Jesse, are you still seeing this? This seems to be worksforme on Linux...
|
Reporter | |
Comment 2•17 years ago
|
||
I'm still seeing the content duplication but not the assertion.
|
|
Assignee | |
Comment 3•17 years ago
|
||
So the problem is that when we're appending the parent frame is the second continuation of the <div>. This does have the "have first letter" bit set, but it's not the right frame to remove the first-letter stuff from. It needs to be removed from the first continuation.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #289945 -
Flags: superreview?(roc)
Attachment #289945 -
Flags: review?(roc)
|
|
Assignee | |
Updated•17 years ago
|
Summary: "ASSERTION: Weird break found!" with -moz-column → [FIX]"ASSERTION: Weird break found!" with -moz-column
Target Milestone: --- → mozilla1.9 M10
Attachment #289945 -
Flags: superreview?(roc)
Attachment #289945 -
Flags: superreview+
Attachment #289945 -
Flags: review?(roc)
Attachment #289945 -
Flags: review+
|
|
Assignee | |
Comment 4•17 years ago
|
||
Well, I checked in the test.. But it fails, because when we recover letter frames we don't recover the inline letter frame on continuations of the block, I guess. Or something. The '!' vertical position is different in the reference and the test. I filed bug 405377 on that.
Patch itself is checked in.
So I've marked it as "fails" for now and filed bug
Flags: in-testsuite?
|
|
Assignee | |
Comment 5•17 years ago
|
||
Should have been 'filed bug 405377'.
But I'm not sure that's the problem now...
|
|
Assignee | |
Updated•17 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Comment 6•17 years ago
|
||
Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b2) Gecko/2007121014 Firefox/3.0b2. Running the testcase attached, i see no assertions nor content duplication.
Status: RESOLVED → VERIFIED
|
|
Reporter | |
Updated•17 years ago
|
Flags: in-testsuite? → in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•