Closed
Bug 403175
Opened 17 years ago
Closed 17 years ago
[FIX]"ASSERTION: Wrong parent style context" with <table align=right>
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
People
(Reporter: jruderman, Assigned: bzbarsky)
References
Details
(Keywords: assertion, testcase)
Attachments
(2 files, 1 obsolete file)
|
(deleted),
text/html
|
Details | |
|
(deleted),
patch
|
roc
:
review+
roc
:
superreview+
mtschrep
:
approval1.9+
|
Details | Diff | Splinter Review |
The testcase triggers the following assertion on about 70% of its iterations.
frame: Placeholder(table)(0) (0x3f988aa8) style: 0x3f988284 :-moz-non-element {}
###!!! ASSERTION: Wrong parent style context: 'Error', file /Users/jruderman/trunk/mozilla/layout/base/nsFrameManager.cpp, line 819
Wrong parent style context: style: 0x3f98b1c0 {}
should be using: style: 0x25d1ea0 {}
|
Assignee | |
Comment 1•17 years ago
|
||
We were using the parent of the outer table's style context, which is the inner table's style context, as the style context parent for the placeholder. We want to be using the parent of the inner table's style context (in this case, the body's style context).
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #288103 -
Flags: superreview?(roc)
Attachment #288103 -
Flags: review?(roc)
|
|
Assignee | |
Updated•17 years ago
|
OS: Mac OS X → All
Hardware: PC → All
Summary: "ASSERTION: Wrong parent style context" with <table align=right> → [FIX]"ASSERTION: Wrong parent style context" with <table align=right>
|
|
Assignee | |
Comment 2•17 years ago
|
||
Attachment #287969 -
Attachment is obsolete: true
Attachment #288104 -
Flags: superreview?(roc)
Attachment #288104 -
Flags: review?(roc)
Attachment #288103 -
Attachment is obsolete: true
Attachment #288103 -
Flags: superreview?(roc)
Attachment #288103 -
Flags: review?(roc)
Attachment #288104 -
Flags: superreview?(roc)
Attachment #288104 -
Flags: superreview+
Attachment #288104 -
Flags: review?(roc)
Attachment #288104 -
Flags: review+
Attachment #288104 -
Flags: approval1.9?
|
||
Updated•17 years ago
|
Attachment #288104 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Comment 3•17 years ago
|
||
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•17 years ago
|
Flags: in-testsuite?
|
||
Comment 4•17 years ago
|
||
Comment on attachment 288104 [details] [diff] [review]
The right patch
>+ NS_PRECONDITION(aStyleDisplay == aNewFrame->GetStyleDisplay(),
>+ "Wrong display struct?");
Splitters don't like this, but then again // XXXbz this is pretty messed up
|
|
||
Comment 5•17 years ago
|
||
Sorry for the spam, I overlooked bug 404218...
|
Reporter | |
Updated•17 years ago
|
Attachment #287969 -
Attachment is obsolete: false
You need to log in
before you can comment on or make changes to this bug.
Description
•