I'm modifying our scintilla plugin to use the new core drawing on trunk. I could not build without a small modification to npapi.h. The issue is NPN_SetValue call (as described at http://wiki.mozilla.org/Mac:NPAPI_Drawing_Models) requires an NPPValue, not an NPNValue. powerpc-apple-darwin8-gcc-4.0.1 (GCC) 4.0.1 considers that an error and the build breaks. I don't necessarily think this is the *right* fix, but I now have scintilla working with carbon on trunk.

meant to assign to Josh, reassigning

Comment on attachment 288241 [details] [diff] [review] osx_plugin_carbondrawing.patch Looks good to me, but this is Josh territory, so asking him to review.

Comment on attachment 288241 [details] [diff] [review] osx_plugin_carbondrawing.patch I'm OK with this, I will submit a patch to WebKit to keep Apple in sync with our change.

My patch for this in WebKit has landed.

Comment on attachment 288241 [details] [diff] [review] osx_plugin_carbondrawing.patch Actually, we should fix one more thing. In ns4xPlugin.cpp, please use the new value in the following function: _setvalue(NPP npp, NPPVariable variable, void *result) Strictly speaking it doesn't really matter since they resolve to the same thing, but it is the right thing to do.

Marking blocking1.9+ since this is a significant problem with a major Gecko 1.9 feature.

Patch updated to address my own review comment, save Shane some time.

landed on trunk, thanks Shane!