Using may23 m16 commercial build We should remove the following items from the "Filters For" account selection dropdown in the Message Filters: Local Folders: remove this unless we implement "Manual Filtering" a.k.a. "After the Fact Filtering" for any folder selection (reference bug #11033 and Message Filters spec, listing manual filtering as P3 -- note the spec has this feature broken into two items, one for manually filtering only the default inbox and the other for manually filtering any folder selection). Even for POP accounts, seamonkey has an inbox within the account hierarchy, Local Folders would not be a valid incoming mailbox. News accounts: remove this item based on M20 target (reference bug #17483) for the backend implementation of news filters. I'm logging this as a tracking bug, I know final decisions are not really FINAL yet.

ah, I need to make the picker only show servers that can accept messages. I know there's an RDF property for that. Adding seth, but I'm sure I can find it myself

nc:CanFileMessages see mailWindowOverlay.xul we use it for move / file menu picker in the 3 pane.

adding keyword b3mail

Adding nsbeta3 to b3mail bugs.

Removing b3mail keyword (these bugs have been promoted now.)

QA note when verifying: Local Folders and News (both account and folder levels) are valid for search ui, verify the fix for this does not affect search ui.

- per mail triage

whoa, this is bad to allow the user to specify filters that won't work! I'll take this bug, and clear the nsbeta3-.

Finally... YAY! Thank you, David!

Plussing on the assumption your fix is to remove the bogus stuff from the UI.

ok, now I'm confused. Is there some other way of fixing this? The bug is to remove them from the selection dropdown. We also need to remove newsgroups from the filter targets.

it's not as easy as it sounds.. I have to reflect the fact that a server can handle filters into RDF, and then filter out the servers that can't hold filters. I'll see what I can do. bienvenu: as for removing invalid filter targets, I have that fix in my tree, since we already have reflected what folders can and cant accept messages.

OK, I'm going to reassign this back to Alec since this would be a lot easier for him. I'll see if he has other bugs that I can work on.

I've started working on this in my tree, I'll post a patch soon

marking in progress so others don't waste time on this

oops created the attachment for the wrong bug. Please ignore the attachment.

ok, that's the first part of the patch, which also fixes the leak described in bug 44626.. adding putterman@netscape.com for a review (XUL patch coming up)

ok, all I need is a review on these three files, and I'm ready to go

r=scottip

fix is in, thanks scott

Thanks *alot* for fixing this, Alec!

In august 28 build: - Good: the filter scope "filters for" selection dropdown doesn't offer invalid servers - Bad: the MoveToFolder action still shows invalid choices. This is mentioned as part of this bug 40343 as Selmer and David mentioned in each of their comments of aug17. Originally that specific area was covered in bug 40357 and bug 40358, both still stand futured. I'm assuming we still mean this bug to cover the bogus invalid selections for the MoveToFolder, too? Or are we going to un-future 40357-58? Reopening for target selection dropdown, comments please.

the other two bugs cover target selection just fine. We may want to consider un-futuring them/renominating them... this bug, as it original stands (and as my patches were for) is just for the Filters for: combo box, which should now be fixed Wouldn't you know it, I have fixes for the other two bugs in my tree, I don't know how long they've been there for! I'll attach to bug 40357, re-nominate, and get a review.

OK using aug30 commercial build, linux rh6.0, NT 4.0 and Mac OS 9.0 Problem with invalid selections in filter actions will be addressed separately, bug 40357.

Removing the mail1 keyword.