Closed Bug 404315 Opened 17 years ago Closed 17 years ago

[FIX]Improve signature of nsICSSParser::Parse

Categories

(Core :: CSS Parsing and Computation, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9beta2

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

Attached patch Like so (deleted) — Splinter Review
As the summary says. Also drops more stuff when done parsing, and even more if we recycle the parser, so we don't keep things alive for a long time.
Attachment #289293 - Flags: superreview?(dbaron)
Attachment #289293 - Flags: review?(dbaron)
Comment on attachment 289293 [details] [diff] [review] Like so r+sr=dbaron. Sorry for the delay here. I wonder if we should move even further to a model where the sheet is input to nsICSSParser::Parse and some of the other methods (instead of a pile of URIs and a principal), and the parser only holds onto it for the duration of those methods.
Attachment #289293 - Flags: superreview?(dbaron)
Attachment #289293 - Flags: superreview+
Attachment #289293 - Flags: review?(dbaron)
Attachment #289293 - Flags: review+
That might not be a bad idea, esp. once we have the mmgc stuff and don't need to refcount all those things as we get them off the sheet.
Comment on attachment 289293 [details] [diff] [review] Like so This is a simple change to make it harder for users of this API to shoot themselves in the foot.
Attachment #289293 - Flags: approval1.9?
Comment on attachment 289293 [details] [diff] [review] Like so a=beltzner for 1.9
Attachment #289293 - Flags: approval1.9? → approval1.9+
Fixed.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Depends on: 419080
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: