Closed
Bug 404315
Opened 17 years ago
Closed 17 years ago
[FIX]Improve signature of nsICSSParser::Parse
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9beta2
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
(deleted),
patch
|
dbaron
:
review+
dbaron
:
superreview+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
As the summary says. Also drops more stuff when done parsing, and even more if we recycle the parser, so we don't keep things alive for a long time.
Attachment #289293 -
Flags: superreview?(dbaron)
Attachment #289293 -
Flags: review?(dbaron)
Comment 1•17 years ago
|
||
Comment on attachment 289293 [details] [diff] [review]
Like so
r+sr=dbaron. Sorry for the delay here.
I wonder if we should move even further to a model where the sheet is input to nsICSSParser::Parse and some of the other methods (instead of a pile of URIs and a principal), and the parser only holds onto it for the duration of those methods.
Attachment #289293 -
Flags: superreview?(dbaron)
Attachment #289293 -
Flags: superreview+
Attachment #289293 -
Flags: review?(dbaron)
Attachment #289293 -
Flags: review+
Assignee | ||
Comment 2•17 years ago
|
||
That might not be a bad idea, esp. once we have the mmgc stuff and don't need to refcount all those things as we get them off the sheet.
Assignee | ||
Comment 3•17 years ago
|
||
Comment on attachment 289293 [details] [diff] [review]
Like so
This is a simple change to make it harder for users of this API to shoot themselves in the foot.
Attachment #289293 -
Flags: approval1.9?
Comment 4•17 years ago
|
||
Comment on attachment 289293 [details] [diff] [review]
Like so
a=beltzner for 1.9
Attachment #289293 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Comment 5•17 years ago
|
||
Fixed.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•17 years ago
|
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•