Closed Bug 404495 Opened 17 years ago Closed 17 years ago

Native GTK style for menu checkboxes

Categories

(Core :: Widget: Gtk, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9beta2

People

(Reporter: micmon, Assigned: ventnor.bugzilla)

Details

Attachments

(2 files)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.8) Gecko/20071022 Ubuntu/7.10 (gutsy) Firefox/2.0.0.8
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2pre) Gecko/2007111904 Minefield/3.0b2pre

The checkboxes in dialog windows (preferences etc) have a nice GTK look now, even checkboxes in webpages look GTK-native in FF3. The only place were the checkboxes look different is the menu. Would be nice if FF3 would pick up the native look here, too.

Reproducible: Always
Attached image Comparison FF3 <-> native (deleted) —
Btw, FF3 is already using GTK native radio buttons in menus.
Component: OS Integration → Widget: Gtk
Product: Firefox → Core
QA Contact: os.integration → gtk
Version: unspecified → Trunk
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attached patch Patch (deleted) — Splinter Review
This seems to do it for me by removing an evil assumption. I'm not sure how this would look under GNOME 2.20 as this computer uses Ubuntu Feisty instead of Gutsy. Any plans to upgrade this thing, Roc?
Assignee: nobody → ventnor.bugzilla
Status: NEW → ASSIGNED
Attachment #290156 - Flags: superreview?(roc)
Attachment #290156 - Flags: review?(roc)
Comment on attachment 290156 [details] [diff] [review]
Patch

Just verify that that style was available in old versions of GTK.
Attachment #290156 - Flags: superreview?(roc)
Attachment #290156 - Flags: superreview+
Attachment #290156 - Flags: review?(roc)
Attachment #290156 - Flags: review+
Comment on attachment 290156 [details] [diff] [review]
Patch

Its been there since 2.8, the oldest documentation I could find. So I think we're safe.
Attachment #290156 - Flags: approval1.9?
I remember someone saying on our little IRC meeting that the lower dependency for GTK was upped to 2.10 for FF3.
(In reply to comment #6)
> I remember someone saying on our little IRC meeting that the lower dependency
> for GTK was upped to 2.10 for FF3.

See http://wiki.mozilla.org/Linux/Runtime_Requirements for the complete list.
Comment on attachment 290156 [details] [diff] [review]
Patch

a=beltzner for drivers
Attachment #290156 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in widget/src/gtk2/gtk2drawing.c;
/cvsroot/mozilla/widget/src/gtk2/gtk2drawing.c,v  <--  gtk2drawing.c
new revision: 1.43; previous revision: 1.42
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M10
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: