Closed
Bug 404636
Opened 17 years ago
Closed 17 years ago
Building without SVG fails
Categories
(Core :: Web Painting, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9beta2
People
(Reporter: romaxa, Assigned: romaxa)
References
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
roc
:
review+
roc
:
superreview+
mtschrep
:
approval1.9+
|
Details | Diff | Splinter Review |
Building without SVG fails
http://mxr.mozilla.org/seamonkey/source/layout/generic/nsLineLayout.cpp#763
You need to #ifdef just the SVG line. the subDocumentFrame check needs to stay there.
|
Assignee | |
Comment 2•17 years ago
|
||
Attachment #289618 -
Flags: review?(roc)
|
||
Comment 3•17 years ago
|
||
Comment on attachment 289618 [details] [diff] [review]
Minimal define
This isn't the right patch.
Attachment #289618 -
Attachment is obsolete: true
Attachment #289618 -
Flags: review?(roc)
|
|
Assignee | |
Comment 4•17 years ago
|
||
Ups, previous attachment was the same....
Attachment #289619 -
Flags: review?(roc)
|
|
||
Updated•17 years ago
|
Assignee: roc → romaxa
|
|
||
Updated•17 years ago
|
Attachment #289558 -
Attachment is obsolete: true
Attachment #289619 -
Flags: superreview+
Attachment #289619 -
Flags: review?(roc)
Attachment #289619 -
Flags: review+
|
|
||
Comment 5•17 years ago
|
||
Comment on attachment 289619 [details] [diff] [review]
Minimal define 2
Simple patch to allow building layout without SVG.
Attachment #289619 -
Flags: approval1.9?
|
|
Assignee | |
Updated•17 years ago
|
Keywords: checkin-needed
|
|
||
Comment 6•17 years ago
|
||
Please don't add checkin-needed until the patch has approval. All patches either need approval1.9+ or the bug must be blocking1.9+/blocking-firefox3+ in order to land.
Keywords: checkin-needed
|
||
Updated•17 years ago
|
Attachment #289619 -
Flags: approval1.9? → approval1.9+
|
|
||
Comment 8•17 years ago
|
||
Checking in layout/generic/nsLineLayout.cpp;
/cvsroot/mozilla/layout/generic/nsLineLayout.cpp,v <-- nsLineLayout.cpp
new revision: 3.285; previous revision: 3.284
done
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M10
|
||
Updated•6 years ago
|
Component: Layout: View Rendering → Layout: Web Painting
You need to log in
before you can comment on or make changes to this bug.
Description
•