Steps to reproduce this assertion in current debug trunk build: - Have at least two tabs opened - Have the option "Warn me when closing multiple tabs" turned on. - Close the window and press "Quit" in the confirmation dialog ###!!! ASSERTION: Uh, IsInModalState() called w/o a reachable top window?: 'Erro r', file c:/mozilla-build/mozilla/dom/src/base/nsGlobalWindow.cpp, line 5251

Sorry, I hit this assertion when Firefox asks to save current tabs on exit and I hit the "Quit" button.

This assertion can also be triggered by pressing Cmd+Q while the dialog from data:text/html,<iframe src="bbb:"></iframe> is visible.

I got this right now when I have started seamonky (browser), opened from it a composer window and after typing in some text I closed the composer window while disacrding the changes. And then it happened. I use current cvs HEAD. ++WEBSHELL 0x82994e0 == 13 ++DOMWINDOW == 25 (0x9c96ccc) [serial = 32] [Outer = (nil)] ++DOMWINDOW == 26 (0x94881ac) [serial = 33] [Outer = 0x9c96ca0] --WEBSHELL 0x82994e0 == 12 --WEBSHELL 0x829ab60 == 11 --WEBSHELL 0x829ad40 == 10 ^G###!!! ASSERTION: Uh, IsInModalState() called w/o a reachable top window?: 'Error', file nsGlobalWindow.cpp, line 5584 Program received signal SIGTRAP, Trace/breakpoint trap. Break (aMsg=0xbffbeb00 "###!!! ASSERTION: Uh, IsInModalState() called w/o a reachable top window?: 'Error', file nsGlobalWindow.cpp, line 5584") at nsDebugImpl.cpp:480 (gdb) where cont [Thread 0xb3a31b90 (LWP 897) exited] (gdb) I have to retype the 'where' output, so briefly: #10 main () at nsSuiteApp.cpp:103 #9 XRE_main () at nsAppRunner.cpp:3154 #8 nsAppStartup::Run () at nsAppStartup.cpp:181 #7 nsBaseAppShell::Run () at nsBaseAppShell.cpp:170 #6 NS_ProcessNextEvent_P () at nsThreadUtils.cpp:227 #5 nsThread::ProcessNextEvent () at nsThread.cpp:510 #4 nsPendingTimeoutRunner::Run () at nsGlobalWindow.cpp:5542 #3 nsGlobalWindow::RunPendingTimeoutsRecursive () at nsGlobalWindow.cpp:5494 #2 nsGlobalWindow::RunTimeout () at nsGlobalWindow.cpp:7569 #1 nsGlobalWindow::IsInModalState () at nsGlobalWindow.cpp:5584 #0 NS_DebugBreak_P () at nsDebugImpl.cpp:360

I hit this on Firefox 3.0 RC2, debug build, Fedora 9 Linux. OS -> All, same steps as comment 1.

Still happens with TRUNK. Build platform target i686-pc-linux-gnu Build tools Compiler Version Compiler flags gcc gcc version 4.3.1 (Gentoo 4.3.1-r1 p1.1) -Wall -W -Wno-unused -Wpointer-arith -Wcast-align -W -Wno-long-long -pedantic -fno-strict-aliasing -pthread -pipe c++ gcc version 4.3.1 (Gentoo 4.3.1-r1 p1.1) -fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-long-long -pedantic -fno-strict-aliasing -fshort-wchar -pthread -pipe Configure arguments --disable-optimize '--enable-debug=-g3\ -O0\ -ggdb' --enable-debug-modules=all --enable-debugger-info-modules --enable-detect-webshell-leaks --enable-svg --enable-svg-renderer-libart --enable-image-decoders=all --with-qtdir=/usr/qt/3 --enable-application=suite --disable-freetype2 --enable-jprof --enable-default-toolkit=cairo-gtk2 --enable-xft --disable-gssapi

The current line is: ###!!! ASSERTION: Uh, IsInModalState() called w/o a reachable top window?: 'Error', file nsGlobalWindow.cpp, line 5741

Bug 511467 has a testcase that triggers this assertion in a different way.

Not holding the release on this assertion.

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1274773608.1274779080.19239.gz Rev3 Fedora 12 mozilla-central debug test mochitest-other on 2010/05/25 00:46:48

I managed to grab a dump with a debug build with m-c 77594:1f800c226837 (today's tip), if anyone is interested. I reproduced by closing one of multiple windows with the "warn when closing" option enabled. It seems to be very similar to the repro in the initial comment.

This is still occurring on trunk, line 6803 now.

I can reproduce this on 2012-05-18-mozilla-central-debug build on Win 7 64-bit.

This bug is reproducible before and after the regression range of bug 757004.

Now line 8888.

I'd review a patch to remove the assertion ;) (it is valid-ish state during shutdown)

Without a try run, just removing an error call.

(In reply to Pulsebot from comment #21) > https://hg.mozilla.org/integration/mozilla-inbound/rev/1777e46a19cb landed as https://hg.mozilla.org/integration/mozilla-inbound/rev/1777e46a19cb to fix m3 test unexpected ok :)

https://hg.mozilla.org/mozilla-central/rev/aaad287aad5a https://hg.mozilla.org/mozilla-central/rev/1777e46a19cb