After an update has been downloaded and is ready to install but before restarting the help menu has an "Apply Downloaded Update Now..." item. Clicking it does nothing. Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b2pre) Gecko/2007112104 Minefield/3.0b2pre ID:2007112104

I don't have the bandwidth to test repeatedly downloading updates, but since the menuitem calls http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/browser/base/content/utilityOverlay.js&rev=1.55&mark=424-425#412 which calls http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/toolkit/mozapps/update/src/nsUpdateService.js.in&rev=1.144&mark=2806-2807#2804 which used to showUI, but after bug 323041 will only showUIWhenIdle, I'll go out on a limb and guess that it does nothing because when you've just selected a menuitem, you haven't been idle for 60 seconds.

Another option would be to add a showUpdateDownloadedWhenIdle method or to handle the idle stuff on the call side, but I think it makes more sense this way.

s/Helds/Holds/

Could not Reproduce.

Comment on attachment 289980 [details] [diff] [review] patch (checked in) looks good, let's get this landed ASAP.

Checking in toolkit/mozapps/update/public/nsIUpdateService.idl; /cvsroot/mozilla/toolkit/mozapps/update/public/nsIUpdateService.idl,v <-- nsIUpdateService.idl new revision: 1.47; previous revision: 1.46 done Checking in toolkit/mozapps/update/src/nsUpdateService.js.in; /cvsroot/mozilla/toolkit/mozapps/update/src/nsUpdateService.js.in,v <-- nsUpdateService.js.in new revision: 1.145; previous revision: 1.144 done

checkForUpdates in utilityOverlay.js must pass both arguments to showUpdateDownloaded.

Comment on attachment 290102 [details] [diff] [review] sync nsIUpdatePrompt consumers (checked in) r=sspitzer (stealing review from mike)

Checking in browser/base/content/utilityOverlay.js; /cvsroot/mozilla/browser/base/content/utilityOverlay.js,v <-- utilityOverlay.js new revision: 1.56; previous revision: 1.55 done Checking in calendar/resources/content/applicationUtil.js; /cvsroot/mozilla/calendar/resources/content/applicationUtil.js,v <-- applicationUtil.js new revision: 1.24; previous revision: 1.23 done Checking in mail/base/content/mailWindowOverlay.js; /cvsroot/mozilla/mail/base/content/mailWindowOverlay.js,v <-- mailWindowOverlay.js new revision: 1.181; previous revision: 1.180 done

verified fixed using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007120505 Minefield/3.0b2pre and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b2pre) Gecko/2007120504 Minefield/3.0b2pre -> Verified