User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b2pre) Gecko/2007112305 Minefield/3.0b2pre Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b2pre) Gecko/2007112305 Minefield/3.0b2pre This is very similar to bug 398409, with the exception that this time it's when you right-click a link and then click 'Bookmark This Link'. Reproducible: Always Steps to Reproduce: 1. Right-click a link. 2. Click 'Bookmark This Link' in context menu. Actual Results: Dialog opens in the top-left corner of the window. Expected Results: Dialog should open in normal place right under star button.

Confirmed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007112423 Minefield/3.0b2pre

Just to confirm what Tracy Walker mentioned in bug 398409 comment 27, the dialog also opens in the wrong place if you right-click any background tab and click 'Bookmark This Tab'.

If the Bookmark dialog appears under the star, it looks like you are bookmarking the url displayed in the location bar. When you select "Bookmark this Link", you are bookmarking a different url.

(In reply to comment #3) > If the Bookmark dialog appears under the star, it looks like you are > bookmarking the url displayed in the location bar. When you select "Bookmark > this Link", you are bookmarking a different url. This is a good point, however, I don't think the top-left is the best place for the dialog to appear. How about for these two cases, the dialog appears in the center of the content pane, like the 'Add Bookmark' dialog you get from right-clicking on a link in the History sidebar -> Bookmark This Link?

With links loaded in the sidebar from an Open in the sidebar bookmark, context click Bookmark this link.. opens the add dialog at the upper left of the sidebar as opposed to the upper left of the content area. I think, for all these cases that aren't explicitly bookmarking the focused page, opening the add bookmark dialog at the center of the title bar similar to what Context click on a tab > Bookmark All Tabs does is a good way to go for consistency. (at least that how it goes on Mac)

also the delete button does not work here on the dialog...

additionally, bookmark this frame is broken (for this reason and for another, see the upcoming patch.) I have a fix for the right click and the frame problem. for the bookmark this tab, the problem is in PCH_bookmarkPage() We fail to find the star icon because we fail this check aBrowser.contentWindow == window.content.

> for this reason and for another, see the upcoming patch - var txn = PlacesUtils.ptm.createItem(uri, PlacesUtils.bookmarksRootId, -1, + var txn = PlacesUtils.ptm.createItem(uri, PlacesUtils.bookmarksMenuFolderId, -1, Some comments: 1) there is copy and pasted code that could be unified 2) mano, do you remember why this check was necessary? aBrowser.contentWindow == window.content

> also the delete button does not work here on the dialog... I have not seen that.

Comment on attachment 293648 [details] [diff] [review] patch clearing review request, until duplicate code is cleaned up.

> 2) mano, do you remember why this check was necessary? aBrowser.contentWindow > == window.content It checks whether the given content window can be associated with the location bar.... (which always has the url loaded in window.content).

That is, this was done implemented this way on purpose, the right fix is to open the popup at-cursor once its styling is fixed.

I've spun off the "bookmark this frame" not working at all problem to bug #408862.

> That is, this was done implemented this way on purpose, the right fix is to > open the popup at-cursor once its styling is fixed. Asaf, can you elaborate on what you mean by "once its styling is fixed"?

There was some talk about a speech-balloon look-and-feel for the panel. Maybe ask Alex?

On the subject of the styling of the panel, is it intended for it to be different from the dialog that pops up when you click the star, in that it doesn't include tagging options?

I can confirm. Version: - Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3) Gecko/2008020511 Firefox/3.0b3 O/S: - Mac OS X version 10.4.11 Machine: - 2.16 GHz Intel Core 2 Duo Macbook Profiles: - Bug occurs when using a default profile Themes: - Bug occurs when using default Firefox theme -- In Firefox/3.0b3, it has a different style from the dialog that appears by the star button. Another idea to consider would be to have it appear next to the mouse cursor or make it easier to see. When I first used this "Bookmark This Link" menuitem in Firefox/3.0b3, I didn't see the dialog right away.

>There was some talk about a speech-balloon look-and-feel for the panel. Maybe >ask Alex? That is the ideal solution, but is it possible to position the window correctly? Other options that might be faster to implement: -open page in a new tab and place the bookmark dialog under the star -put the bookmark dialog in an actual window

Not blocking on this bug for final ship. Would take a safe enough patch if one comes through.

The same behavior can be seen by using following steps: 1. Open a website and wait until it finished loading 2. Hit Ctrl+L to switch the focus to the location bar 3. Clear the location bar 4. Hit Ctrl+D This also places the Bookmark Contextual Dialog in the top-left corner of the window.

Henrik: that's bug 427039.

bug 411261 has moved the dialog for "bookmark this link" in a window, so this is fixed now. Still valid is instead bug 454534.

Verified with: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2pre) Gecko/20081114 Minefield/3.1b2pre ID:20081114034305 Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081117 Minefield/3.1b2pre ID:20081117110034

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h". In Thunderbird 3.0b, you do that as follows: Tools | Message Filters Make sure the correct account is selected. Click "New" Conditions: Body contains places-to-b-and-h Change the action to "Delete Message". Select "Manually Run" from the dropdown at the top. Click OK. Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter. Gerv