Closed Bug 405552 Opened 17 years ago Closed 17 years ago

Crash [@ nsHyperTextAccessible::ContentToRenderedOffset ]

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: aaronlev, Assigned: aaronlev)

References

Details

(Keywords: access, crash)

Crash Data

Attachments

(1 file, 2 obsolete files)

Blocks: fox3access
Comment on attachment 290320 [details] [diff] [review] 1) Don't fire text change events if text is not rendered, 2) if null frame passed in, return a rendered offset of 0, since nothing is rendered It looks OK, except > NS_IMETHODIMP nsDocAccessible::Destroy() > { >+ nsresult rv = Shutdown(); >+ > if (mWeakShell) { >+ // Remove from the cache after Shutdown(), so that Shutdown() procedures >+ // can find the doc or root accessible in the cache if they need it > gGlobalDocAccessibleCache.Remove(static_cast<void*>(mWeakShell)); > } >- return Shutdown(); >+ return rv; > } > This change seems about some other bug, isn't it? |this| is the doc or root acccessible, I can't think of a case that we need to find it in the cache. And nsAccessNode::Shutdown() will set mWeakShell to null.
Sorry, that was from a different patch.
Attached patch Correct patch (obsolete) (deleted) — Splinter Review
Attachment #290320 - Attachment is obsolete: true
Attachment #290326 - Flags: review?
Attachment #290320 - Flags: review?(Evan.Yan)
Attached patch Correct patch (deleted) — Splinter Review
Attachment #290327 - Flags: review?(Evan.Yan)
Attachment #290326 - Attachment is obsolete: true
Attachment #290326 - Flags: review?
Attachment #290327 - Flags: review?(Evan.Yan) → review+
Attachment #290327 - Flags: approval1.9?
Attachment #290327 - Flags: approval1.9? → approval1.9+
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Crash Signature: [@ nsHyperTextAccessible::ContentToRenderedOffset ]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: