Closed
Bug 406373
Opened 17 years ago
Closed 17 years ago
Url bar results can be scrolled horizontally after scrolling vertically
Categories
(Firefox :: Address Bar, defect, P4)
Firefox
Address Bar
Tracking
()
VERIFIED
FIXED
Firefox 3 beta5
People
(Reporter: Mardak, Assigned: Mardak)
References
Details
(Whiteboard: [fixed by bug 421412])
Attachments
(1 file)
(deleted),
image/png
|
Details |
Might be mac-only.. tested with my iBook and stephend on macbook pro.
1) Type something into location bar to have results appear
2) Scroll down with the 2-finger-scrolling
3) Scroll right with the 2-finger-scrolling
expect: no side scrolling
actual: scrolls to the side.. see attachment
Might also be 2-finger-scrolling specific as well... ?
Updated•17 years ago
|
Flags: blocking-firefox3?
Comment 1•17 years ago
|
||
I need to google 2-finger scrolling, but I can imagine how this would be possible given that I use a scroll box.
from autocomplete.xml:
1067 <xul:scrollbox anonid="title-scrollbox" class="ac-title">
1068 # note, we rely on the newlines here so that we have
1069 # a textNode before and after the span. see _setUpDescription()
1070 # for more details
1071 <xul:description anonid="title" class="ac-normal-text ac-comment" xbl:inherits="selected">
1072 <xul:label class="ac-emphasize-text"/>
1073 </xul:description>
1074 </xul:scrollbox>
I might need overflow:-moz-hidden-unscrollable; on the actual scrollbox.
Assignee | ||
Comment 2•17 years ago
|
||
Doing that causes the title to not crop but the url correctly crops right. (Still scrollable because now the title text goes off the edge.)
Comment 3•17 years ago
|
||
Seth: 2-finger scrolling is the same as using any other scroll-wheel that supports side-to-side scrolling.
We should probably disable it for the richlisttextbox, as it's pretty unexpected.
Comment 4•17 years ago
|
||
ok, thanks beltzner. I can reproduce this now.
Updated•17 years ago
|
Component: Places → Location Bar and Autocomplete
QA Contact: places → location.bar
Comment 5•17 years ago
|
||
I'd try:
.autocomplete-richlistbox > scrollbox > .scrollbox-innerbox {
overflow-x: hidden;
}
But I'm unable to trigger the bug, so I can't test this.
Assignee | ||
Comment 6•17 years ago
|
||
overflow-x: hidden on any of those 3 elements doesn't seem to help. (used dom inspector and added the styles)
Comment 7•17 years ago
|
||
Maybe there's no way around adding overflow[-x]:hidden to all richlistitems, which I think is what Seth did initially.
Comment 8•17 years ago
|
||
hmm, I can't reproduce on current trunk. Seth, did you fix this somehow?
Assignee | ||
Comment 9•17 years ago
|
||
I can still reproduce on the 2007121107 build.
I can scroll horizontally only after scrolling vertically, but if I move the cursor out of the popup and back in, I can't scroll horizontally until scrolling vertically again.
Updated•17 years ago
|
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P3
Target Milestone: --- → Firefox 3 M11
Assignee | ||
Comment 10•17 years ago
|
||
There seems to be potential for the bug to appear even if there is fewer items than needed to cause the vertical scrollbar to appear. But I'm unable to scroll horizontally without a vertical scrollbar. So, I'm thinking there's a bug with the scroll code that handles the special "ticks" generated by the 2-finger scrolling.
If I type in something to the location bar that has 2 results..
richlistbox: computed width 540.8px
scrollbox: computed width 540.8px
innerbox: computed width 615.2px
richlistitems: current_width 540.8000.., computed width 613.2px
titlescrollbox: min/maxwidth 459.8000.., computed width 459px
hbox containing title: computed width 613.2px
urlscrollbox: min/maxwidth 463.8000.., computed width 463px
hbox containing url: 613.2px
vbox containing the 2 hboxes: computed width 613.2px
Both the title and url require ellipses. It seems like the computed width of the hboxes containing the title or url will expand if the content was long enough before adding ellipses.
The other richlistitem has smaller content and the hboxes inside are the correct computed widths, but the richlistitem's computed width is also 613.2px probably because its sibling has that width and forced the innerbox to expand.
Comment 11•17 years ago
|
||
martijn's patch for bug #408621 fixes this problem.
Assignee: nobody → martijn.martijn
Depends on: 408621
Updated•17 years ago
|
Priority: P3 → P4
Assignee | ||
Comment 13•17 years ago
|
||
Seems like bug 421412 fixed this.
Assignee: martijn.martijn → edilee
Depends on: 421412
Flags: in-litmus?
OS: Mac OS X → All
Hardware: Macintosh → All
Whiteboard: [fixed by bug 421412]
Target Milestone: Firefox 3 beta3 → Firefox 3 beta5
Assignee | ||
Updated•17 years ago
|
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
in-litmus+
https://litmus.mozilla.org/show_test.cgi?id=5223
Verified FIXED using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b5pre) Gecko/2008032404 Minefield/3.0b5pre
Status: RESOLVED → VERIFIED
Flags: in-litmus? → in-litmus+
You need to log in
before you can comment on or make changes to this bug.
Description
•