Closed
Bug 406456
Opened 17 years ago
Closed 17 years ago
Firefox site button should have only one tooltip
Categories
(Firefox :: Address Bar, defect, P2)
Firefox
Address Bar
Tracking
()
VERIFIED
FIXED
Firefox 3 beta5
People
(Reporter: chadwickgab+mozilla, Assigned: johnath)
References
Details
Attachments
(2 files)
(deleted),
image/jpeg
|
Details | |
(deleted),
patch
|
beltzner
:
review+
beltzner
:
ui-review+
|
Details | Diff | Splinter Review |
Firefox button should have only one tooltip when on unsecured website or in minimized mode. Like current setting on the trunk. To tooltips for the same button is confusing and useless IMO.
Flags: blocking-firefox3?
Reporter | ||
Comment 1•17 years ago
|
||
(In reply to comment #0)
> To tooltips for the samebutton is confusing and useless IMO.
>
I meant two tooltips...
Comment 2•17 years ago
|
||
I'm pretty sure that there is already a bug for this.
Comment 3•17 years ago
|
||
(In reply to comment #2)
> I'm pretty sure that there is already a bug for this.
>
No sorry, that was Bug 396136.
Assignee | ||
Comment 4•17 years ago
|
||
I agree that this is pretty confusing. Part of the confusion comes from bug 402260 - because the text label that accompanied the site button has been (temporarily) hidden, the non-favicon area is now quite small, leading to the odd behaviour. If that bug is reversed as intended, then this one should be a non-issue, I'd argue (since we do still want people to know that they can dragdrop the favicon.)
Reporter | ||
Comment 5•17 years ago
|
||
I understant that this is not an issue on secured website with the text label... This will stay an issue an a unsecured website even if the text label is back. That is why I think it should block.
Comment 6•17 years ago
|
||
True, I can get the behaviour on pages that provide no site information, either.
We should just remove the "drag this favicon" tooltip entirely.
Updated•17 years ago
|
Flags: wanted-firefox3+
Flags: blocking-firefox3?
Flags: blocking-firefox3-
Priority: -- → P5
Target Milestone: --- → Firefox 3 M11
Reporter | ||
Comment 7•17 years ago
|
||
Is there anyone that disagrees on this change for site without identity information ? If not I think it is more than an easy change and helps for a new function (the site button) discoverability ! Should be made +++ (If only I new how to code)
Reporter | ||
Comment 8•17 years ago
|
||
Freeze is passed passing to beta4.
Target Milestone: Firefox 3 beta3 → Firefox 3 beta4
Assignee | ||
Comment 9•17 years ago
|
||
(In reply to comment #6)
> True, I can get the behaviour on pages that provide no site information,
> either.
>
> We should just remove the "drag this favicon" tooltip entirely.
>
Done. Removing the associated string as well, I don't *think* that qualifies as late-l10n.
Assignee: nobody → johnath
Status: NEW → ASSIGNED
Attachment #308475 -
Flags: ui-review?(beltzner)
Attachment #308475 -
Flags: review?(mconnor)
Reporter | ||
Comment 10•17 years ago
|
||
I know very little about mozilla code but would the best behaviour for the patch be to change the tooltips text to the rest of the site button at the place of removing the tooltip completely ? The site icon should still have a tooltip. The one of the site button IMO.
Assignee | ||
Comment 11•17 years ago
|
||
(In reply to comment #10)
> I know very little about mozilla code but would the best behaviour for the
> patch be to change the tooltips text to the rest of the site button at the
> place of removing the tooltip completely ? The site icon should still have a
> tooltip. The one of the site button IMO.
Yes, this patch has that effect. The current code:
http://mxr.mozilla.org/mozilla/source/browser/base/content/browser.js#6452
sets the site-button tooltip on the entire identity-box, including the icon. However, the hard-coded tooltip on the icon was more-specific, and hence over-riding that tooltip when the mouse was directly over the icon (though the site button tooltip would show up if you hovered *just off* the icon). By removing the icon's hardcoded tooltip, the one set in code will apply to the entire site button.
Comment 12•17 years ago
|
||
The site identity button has become one of the marquee features in Firefox 3. Who knew. This needs to be fixed.
Flags: blocking-firefox3- → blocking-firefox3+
Priority: P5 → P2
Target Milestone: Firefox 3 beta4 → Firefox 3 beta5
Comment 13•17 years ago
|
||
Comment on attachment 308475 [details] [diff] [review]
Remove "drag favicon" tooltip
r+uir=beltzner
Attachment #308475 -
Flags: ui-review?(beltzner)
Attachment #308475 -
Flags: ui-review+
Attachment #308475 -
Flags: review?(mconnor)
Attachment #308475 -
Flags: review+
Assignee | ||
Comment 14•17 years ago
|
||
tagging late-l10n for the string removal, just in case.
Keywords: late-l10n
Assignee | ||
Comment 15•17 years ago
|
||
Checking in browser/base/content/browser.xul;
/cvsroot/mozilla/browser/base/content/browser.xul,v <-- browser.xul
new revision: 1.445; previous revision: 1.444
done
Checking in browser/locales/en-US/chrome/browser/browser.dtd;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/browser.dtd,v <-- browser.dtd
new revision: 1.103; previous revision: 1.102
done
Spoke to Axel on IRC, confirmed that string removals do not turn l10n trees red, removing late-l10n keyword
Reporter | ||
Comment 16•17 years ago
|
||
Verified Mozilla/5.0 (Windows; U; Windows NT 6.0; fr; rv:1.9b5pre) Gecko/2008031304 Minefield/3.0b5pre ID:2008031304
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•