Closed
Bug 406458
Opened 17 years ago
Closed 17 years ago
stop using NATIVE_THEBES_CONTEXT
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
People
(Reporter: vlad, Assigned: vlad)
Details
Attachments
(1 file)
|
(deleted),
patch
|
pavlov
:
review+
pavlov
:
approval1.9+
|
Details | Diff | Splinter Review |
We have a pile of code that does:
nsRefPtr<gfxContext> ctx = static_cast<gfxContext*>(aRenderingContext.GetNativeGraphicData(nsIRenderingContext::NATIVE_THEBES_CONTEXT));
this sucks, and should be:
nsRefPtr<gfxContext> ctx = aRenderingContext.ThebesContext();
patch coming up.
|
Assignee | |
Comment 1•17 years ago
|
||
Like so -- stop using (but don't get rid of) NATIVE_THEBES_CONTEXT to simplify all this code.
Attachment #291470 -
Flags: review?(pavlov)
|
||
Updated•17 years ago
|
Attachment #291470 -
Flags: review?(pavlov) → review+
|
|
Assignee | |
Comment 2•17 years ago
|
||
Checked in this cleanup.
|
|
Assignee | |
Updated•17 years ago
|
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Comment 3•17 years ago
|
||
Why was the approval process ignored in this bug?
|
|
||
Comment 4•17 years ago
|
||
Comment on attachment 291470 [details] [diff] [review]
do the change
reed: to annoy you.
Attachment #291470 -
Flags: approval1.9+
|
|
||
Comment 5•17 years ago
|
||
*hug*
You need to log in
before you can comment on or make changes to this bug.
Description
•