Closed
Bug 406621
Opened 17 years ago
Closed 17 years ago
off-by-one losing entries while downloading safebrowsing data
Categories
(Toolkit :: Safe Browsing, defect, P2)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
People
(Reporter: dcamp, Assigned: dcamp)
References
Details
Attachments
(1 file)
(deleted),
patch
|
tony
:
review+
damons
:
approval1.9+
|
Details | Diff | Splinter Review |
While debugging this week I noticed an off-by-one that'll result in losing a single entry per chunk.
The attached patch fixes that, and makes chunk size/expected chunk size mismatches fatal so we'll notice stuff like this quicker next time.
Flags: blocking-firefox3?
Attachment #291258 -
Flags: review?(tony)
Updated•17 years ago
|
Assignee: nobody → dcamp
Updated•17 years ago
|
Status: NEW → ASSIGNED
Version: unspecified → Trunk
Comment 1•17 years ago
|
||
Comment on attachment 291258 [details] [diff] [review]
fix
Would it be hard to add a unittest for this?
Attachment #291258 -
Flags: review?(tony) → review+
Assignee | ||
Comment 2•17 years ago
|
||
It'll be a bit tough, but not impossible. I filed 406634 to update the tests.
Assignee | ||
Updated•17 years ago
|
Attachment #291258 -
Flags: approval1.9?
Updated•17 years ago
|
Attachment #291258 -
Flags: approval1.9? → approval1.9+
Updated•17 years ago
|
Whiteboard: [needs landing]
Assignee | ||
Comment 3•17 years ago
|
||
Checking in src/nsUrlClassifierDBService.cpp;
/cvsroot/mozilla/toolkit/components/url-classifier/src/nsUrlClassifierDBService.cpp,v <-- nsUrlClassifierDBService.cpp
new revision: 1.42; previous revision: 1.41
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•17 years ago
|
Whiteboard: [needs landing]
Updated•17 years ago
|
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P2
Updated•10 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•