Closed Bug 406621 Opened 17 years ago Closed 17 years ago

off-by-one losing entries while downloading safebrowsing data

Categories

(Toolkit :: Safe Browsing, defect, P2)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: dcamp, Assigned: dcamp)

References

Details

Attachments

(1 file)

Attached patch fix (deleted) — Splinter Review
While debugging this week I noticed an off-by-one that'll result in losing a single entry per chunk. The attached patch fixes that, and makes chunk size/expected chunk size mismatches fatal so we'll notice stuff like this quicker next time.
Flags: blocking-firefox3?
Attachment #291258 - Flags: review?(tony)
Assignee: nobody → dcamp
Status: NEW → ASSIGNED
Version: unspecified → Trunk
Comment on attachment 291258 [details] [diff] [review] fix Would it be hard to add a unittest for this?
Attachment #291258 - Flags: review?(tony) → review+
It'll be a bit tough, but not impossible. I filed 406634 to update the tests.
Attachment #291258 - Flags: approval1.9?
Attachment #291258 - Flags: approval1.9? → approval1.9+
Whiteboard: [needs landing]
Checking in src/nsUrlClassifierDBService.cpp; /cvsroot/mozilla/toolkit/components/url-classifier/src/nsUrlClassifierDBService.cpp,v <-- nsUrlClassifierDBService.cpp new revision: 1.42; previous revision: 1.41 done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P2
Blocks: 406865
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: