Closed
Bug 406666
Opened 17 years ago
Closed 17 years ago
Identity popup needs aligning
Categories
(Firefox :: General, defect, P4)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 3 beta3
People
(Reporter: micmon, Assigned: johnath)
Details
(Keywords: polish)
Attachments
(5 files, 1 obsolete file)
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
patch
|
Gavin
:
review+
mtschrep
:
approval1.9+
|
Details | Diff | Splinter Review |
(deleted),
image/png
|
Details |
The text in the identity popup needs to be aligned somehow... right now it looks very weird, as if it just displays random information.
Reporter | ||
Comment 1•17 years ago
|
||
I hope this shows what I mean...
Comment 2•17 years ago
|
||
Also, "Tell me more about this web site..." should never be cropped (visible on your second screenshot).
Component: Page Info → General
Flags: blocking-firefox3?
Keywords: polish
QA Contact: page.info → general
Updated•17 years ago
|
OS: Linux → All
Hardware: PC → All
Assignee | ||
Comment 3•17 years ago
|
||
I think this should fix it - can I get linux and windows confirmation before I ask for review/approval?
Assignee: nobody → johnath
Status: NEW → ASSIGNED
Updated•17 years ago
|
Flags: wanted-firefox3+
Flags: blocking-firefox3?
Flags: blocking-firefox3-
Priority: -- → P4
Target Milestone: --- → Firefox 3 M11
Comment 4•17 years ago
|
||
Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9b2pre)
Gecko/2007121012 Minefield/3.0b2pre - looks good on fedora f8
Assignee | ||
Comment 5•17 years ago
|
||
Mac seems to align perfectly with this patch, but linux seems to still inset the title and link less than the other text. Those two are <label> tags, whereas the rest are <descriptions>, which is likely the source of the discrepancy - do labels have different global styling in gnomestripe?
Assignee | ||
Comment 6•17 years ago
|
||
Windows and Linux were both showing indentation which it turns out is caused by:
http://mxr.mozilla.org/mozilla/source/toolkit/themes/winstripe/global/formatting.css#146
Toolkit gives descriptions a 5px margin in winstripe, but not in pinstripe. This version zeroes it out for the identity popup.
Attachment #291463 -
Attachment is obsolete: true
Attachment #292490 -
Flags: review?(gavin.sharp)
Updated•17 years ago
|
Attachment #292490 -
Flags: review?(gavin.sharp) → review+
Comment 7•17 years ago
|
||
Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9b2pre)
Gecko/2007121016 Minefield/3.0b2pre - tryserver build
Assignee | ||
Comment 8•17 years ago
|
||
Comment on attachment 292490 [details] [diff] [review]
Zero margin-left on windows/linux
Nom'ng for approval. This is a polish bug, low risk, CSS only.
Attachment #292490 -
Flags: approval1.9?
Updated•17 years ago
|
Attachment #292490 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Comment 9•17 years ago
|
||
Checking in browser/themes/gnomestripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/browser.css,v <-- browser.css
new revision: 1.146; previous revision: 1.145
done
Checking in browser/themes/pinstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/browser.css,v <-- browser.css
new revision: 1.102; previous revision: 1.101
done
Checking in browser/themes/winstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/browser.css,v <-- browser.css
new revision: 1.142; previous revision: 1.141
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•