spinoff of Bug 396695 to assist in the future for bugs that need logging during startup.

This adds file logging for certain failure cases that shouldn't happen in normal use. It also removes the now redundant updateTargetAppInfo function.

Comment on attachment 291390 [details] [diff] [review] patch rev 1 Looks good.

Comment on attachment 291390 [details] [diff] [review] patch rev 1 This adds logging for the generally never reached failure cases in the extension manager. This is important to allow us to track down what might have caused problems on a user's machine when we can't reproduce locally.

Checking in toolkit/mozapps/extensions/src/nsExtensionManager.js.in; /cvsroot/mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in,v <-- nsExtensionManager.js.in new revision: 1.266; previous revision: 1.265 done

Comment on attachment 291390 [details] [diff] [review] patch rev 1 This has been on trunk for a few weeks with no reported issues and it's existance means that we can gather far more detailed information about problems during startup than was previously possible so requesting branch approval. As per the previous trunk approval request this only really has any effect when things are going wrong anyway and in that case just writes some additional information to a disk based log file.

Comment on attachment 291390 [details] [diff] [review] patch rev 1 Looks mostly OK, but how big is this log file going to get, and how would a user clear it/know about it?

(In reply to comment #6) > (From update of attachment 291390 [details] [diff] [review]) > Looks mostly OK, but how big is this log file going to get, and how would a > user clear it/know about it? Currently there is no way to clear the log. However I would not expect it to be getting large, it should only ever be written to when there is something wrong happening that would be leading to problems using extensions in the first place.

Comment on attachment 291390 [details] [diff] [review] patch rev 1 Have to turn this down for the branch, it's a "nice to have" but we'd really like to see how it goes on the trunk for a bit first.