Closed
Bug 406779
Opened 17 years ago
Closed 17 years ago
Clicking site/identity button should restore location bar contents
Categories
(Firefox :: Address Bar, defect)
Firefox
Address Bar
Tracking
()
VERIFIED
FIXED
Firefox 3 beta4
People
(Reporter: johnath, Assigned: ehsan.akhgari)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
asaf
:
review+
mtschrep
:
approval1.9+
|
Details | Diff | Splinter Review |
In bug 397594, beltzner suggested a follow up bug to track the idea that clicking on the site button ("identity-box" in browser.xul) should restore the location bar in the case where any edits have been made, to prevent confusion in the case where you are viewing SiteA, but have edited the location bar to point to SiteB. This function is currently accomplished (at least on Mac) via hitting Esc.
Assignee | ||
Comment 1•17 years ago
|
||
Sorry for stealing this bug, Johnathan! :-)
This simple patch fixes this problem.
Reporter | ||
Comment 2•17 years ago
|
||
(In reply to comment #1)
> Sorry for stealing this bug, Johnathan! :-)
>
> This simple patch fixes this problem.
No apology necessary, Ehsan. You've been doing some great work lately, thanks!
Comment 3•17 years ago
|
||
Comment on attachment 303071 [details] [diff] [review]
Patch (v1)
r=mano
Attachment #303071 -
Flags: review?(mano) → review+
Assignee | ||
Comment 4•17 years ago
|
||
Comment on attachment 303071 [details] [diff] [review]
Patch (v1)
This patch has a simple implementation, but results in a big win by keeping the information in the identity dialog in sync with those in the URL bar. Seeking approval to land this.
Attachment #303071 -
Flags: approval1.9?
Updated•17 years ago
|
Attachment #303071 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Updated•17 years ago
|
Keywords: checkin-needed
Reporter | ||
Comment 6•17 years ago
|
||
I'll check this in today.
Reporter | ||
Comment 7•17 years ago
|
||
Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v <-- browser.js
new revision: 1.967; previous revision: 1.966
done
Thanks Ehsan, I appreciate your work on this stuff.
Comment 8•17 years ago
|
||
Verified with:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008022504 Minefield/3.0b4pre
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b4pre) Gecko/2008022504 Minefield/3.0b4pre ID:2008022504
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•