Closed
Bug 406856
Opened 17 years ago
Closed 17 years ago
url-classifier not handling expiration ranges
Categories
(Toolkit :: Safe Browsing, defect, P1)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
People
(Reporter: dcamp, Assigned: dcamp)
References
Details
Attachments
(2 files)
|
(deleted),
patch
|
tony
:
review+
damons
:
approval1.9+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
tony
:
review+
|
Details | Diff | Splinter Review |
Apparently expirations can be ranges of chunks, not just a single chunk. Attached patch handles that case.
Attachment #291512 -
Flags: review?(tony)
|
Assignee | |
Updated•17 years ago
|
Flags: blocking-firefox3?
|
||
Comment 1•17 years ago
|
||
Comment on attachment 291512 [details] [diff] [review]
v1
Looks good, thanks for the tests!
Attachment #291512 -
Flags: review?(tony) → review+
|
|
Assignee | |
Comment 2•17 years ago
|
||
Comment on attachment 291512 [details] [diff] [review]
v1
This is another pretty bad update bug that'd be nice to get in for beta2.
Attachment #291512 -
Flags: approval1.9?
|
||
Updated•17 years ago
|
Attachment #291512 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Comment 3•17 years ago
|
||
Checking in src/nsUrlClassifierDBService.cpp;
/cvsroot/mozilla/toolkit/components/url-classifier/src/nsUrlClassifierDBService.cpp,v <-- nsUrlClassifierDBService.cpp
new revision: 1.43; previous revision: 1.42
done
Checking in tests/unit/test_dbservice.js;
/cvsroot/mozilla/toolkit/components/url-classifier/tests/unit/test_dbservice.js,v <-- test_dbservice.js
new revision: 1.8; previous revision: 1.7
done
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•17 years ago
|
Flags: in-testsuite+
|
||
Updated•17 years ago
|
Flags: blocking-firefox3? → blocking-firefox3+
|
|
Assignee | |
Comment 4•17 years ago
|
||
I'm reopening this bug because the fix is incomplete. Expirations can actually be complete chunk lists, not just chunk ranges.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 5•17 years ago
|
||
This followup patch fixes the expirations to handle complete lists, not just single items or ranges.
As a side effect it should significantly reduce allocations when parsing chunk lists (which will let us close 403354).
Attachment #301772 -
Flags: review?(tony)
|
|
||
Updated•17 years ago
|
Attachment #301772 -
Flags: review?(tony) → review+
|
||
Updated•17 years ago
|
Priority: -- → P1
|
|
Assignee | |
Comment 6•17 years ago
|
||
Checking in src/nsUrlClassifierDBService.cpp;
/cvsroot/mozilla/toolkit/components/url-classifier/src/nsUrlClassifierDBService.cpp,v <-- nsUrlClassifierDBService.cpp
new revision: 1.59; previous revision: 1.58
done
Checking in tests/unit/test_addsub.js;
/cvsroot/mozilla/toolkit/components/url-classifier/tests/unit/test_addsub.js,v <-- test_addsub.js
new revision: 1.6; previous revision: 1.5
done
Status: REOPENED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•