It still works for other things such as Terminal.app, but I can't switch Firefox windows with the keyboard on OS X.

Wierd. The problem started with today's nightly (2007-12-05-04-trunk), so it might be caused by: http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-12-04+16%3A08%3A00&maxdate=2007-12-04+16%3A08%3A00&cvsroot=%2Fcvsroot

That's a pretty good guess.

And now I've confirmed it -- adding the bug 376077 patch to my testing build triggers the bug.

This fixes the problem. I'm pretty sure I want to go with this patch, but in the interest of time and getting more eyes on it, I'm posting this a little before I normally would. I want to think about it a little more.

Comment on attachment 291727 [details] [diff] [review] fix v1.0 This looks fine and works fine (I tested in Minefield). I don't know if any other system key-combos will need to be special-cased ... but now there's a convenient place to do so. I do have one minor quibble: The lack of parentheses in the line beginning "if ..." makes me nervous. The line doesn't need them -- operator precedence makes it work like it should. But I had to look up the precedence rules to be sure of this. I think the line would be easier to read if you changed it to (line deliberately broken to stop it being mangled by Bugzilla): if (([theEvent modifierFlags] & NSCommandKeyMask) && ([theEvent keyCode] == kTildeKeyCode))

backed out 376077, please leave this as a dep so I can remember this when I re-do the fix for that bug