Closed
Bug 40721
Opened 24 years ago
Closed 20 years ago
Height change in nested table no longer causes containing table to be resized
Categories
(Core :: Layout: Tables, defect, P3)
Tracking
()
RESOLVED
WORKSFORME
mozilla0.8
People
(Reporter: wd, Assigned: karnaze)
Details
(Keywords: regression, testcase, Whiteboard: [nsbeta2-] fix-in-hand)
Attachments
(5 files)
(deleted),
text/html
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
text/html
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
karnaze
:
review+
kinmoz
:
superreview+
|
Details | Diff | Splinter Review |
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; m16) Gecko/20000525
BuildID: 2000052520
the CSS Style Visibility:collapse causes a row from a table to collapse. That
works fine. But if there is a table containing this table that collapses, the
outside table is no longer resized to fit accordingly. (It does not shrink
when the inside table is collapsed)
Reproducible: Always
Steps to Reproduce:
1.Go to http://www.abika.com
2.Click one of the items in the table on the left side of the screen
3.Click the same item again (to contract the sub-list)
Actual Results: The outside table is expanded fine when the visibility is set
to "visible". But when the visibility is set to "collapse" the outside table
does not shrink back to original size.
Expected Results: The outside table shrinks back to fit collapsed inside table.
This is a regression which occurred between builds 200002508 and 200002520.
The current build (200002608) also has the same problem.
Assignee | ||
Comment 2•24 years ago
|
||
Changing summary from "[Regression] visibility:collapse no longer causes
containing table to be resized" to "[Regression] height change in nested table
no longer causes containing table to be resized" since there are a lot of other
conditions affected.
Status: NEW → ASSIGNED
Summary: [Regression] visibility:collapse no longer causes containing table to be resized → [Regression] height change in nested table no longer causes containing table to be resized
Assignee | ||
Comment 3•24 years ago
|
||
Assignee | ||
Comment 4•24 years ago
|
||
Nominating for nsbeta2 since it is a recent regression, it is fixed, and has
little risk.
Keywords: nsbeta2
Whiteboard: fix-in-hand
Comment 5•24 years ago
|
||
[nsbeta2+] will take fix until [6/22]
Keywords: regression
Summary: [Regression] height change in nested table no longer causes containing table to be resized → Height change in nested table no longer causes containing table to be resized
Whiteboard: fix-in-hand → [nsbeta2+] [6/22] fix-in-hand
Comment 6•24 years ago
|
||
Adding testcase keyword so this doesn't show up on the bugathon search page.
Keywords: testcase
Assignee | ||
Comment 7•24 years ago
|
||
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
This is now broken again in 2000061608
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 10•24 years ago
|
||
I backed out the change yesterday, thinking it might have contributed to the
problems. I'll probably add it back tomorrow.
Comment 11•24 years ago
|
||
Cleaning up whiteboard and changing to beta2 minus (6/22 has passed).
I saw in the white-board "fix in hand," but the comment above suggests that this
was fixed, then backed out, then was "going" to be fixed again.
I can't quite figure out what the status is... so it would be good to summarize
where we are, and possibly nominate for beta3 if needed.
Thanks,
Jim
Whiteboard: [nsbeta2+] [6/22] fix-in-hand → [nsbeta2-] fix-in-hand
Reporter | ||
Comment 12•24 years ago
|
||
Some more strangeness:
Open the Simplified Testcase for this bug. Click the button 3 times. Poof!
All gone! If the outer, containing table is removed, this behavior does not
occur.
For a more involved testcase, visit the above URL: http://www.abika.com
and click any of the links in the "Information Center". All of the sub-
categories are expanded when only the one clicked should be.
Reporter | ||
Comment 13•24 years ago
|
||
Assignee | ||
Comment 14•24 years ago
|
||
I've put back the patch. It was backed out at a time when the tree was in
trouble and had nothing to do with it.
Status: REOPENED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 16•24 years ago
|
||
I haven't been following closely, so I don't know exactly when it happened, but
as of 2000081020, this bug is now back.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Reporter | ||
Comment 17•24 years ago
|
||
Karnaze, any word on this? Did you back out your changes again, or is
something else now causing this?
Assignee | ||
Comment 18•24 years ago
|
||
I didn't back out the fix a 2nd time.
Assignee | ||
Comment 20•24 years ago
|
||
Comment 21•24 years ago
|
||
I don't the table code well enough to say it will fix the bug, but it does look
right.
r=rods
Comment 22•24 years ago
|
||
sr=buster
Assignee | ||
Comment 23•24 years ago
|
||
The patch was checked in.
Status: REOPENED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
Comment 25•23 years ago
|
||
The problem no longer exist.. Marking verified on 2001-07-27-00-0.9.2 build
Status: RESOLVED → VERIFIED
Comment 26•22 years ago
|
||
Comment on attachment 21019 [details] [diff] [review]
revised patch (previous one is based on old code)
- TallestCellGotShorter(oldCellDesAscent, initCellDesDescent,
- cellMet.descent, mMaxCellDescent);
+ TallestCellGotShorter(oldCellDesAscent, cellMet.descent,
mMaxCellDescent);
Looks like there was an inadvertent typo:
s/oldCellDesAscent/oldCellDesDescent/
Comment 27•22 years ago
|
||
karnaze/kin, r/sr?
Comment 28•22 years ago
|
||
Comment on attachment 101183 [details] [diff] [review]
little patch to fix the typo
sr=kin@netscape.com
Attachment #101183 -
Flags: superreview+
Assignee | ||
Comment 29•22 years ago
|
||
Comment on attachment 101183 [details] [diff] [review]
little patch to fix the typo
r=karnaze
Attachment #101183 -
Flags: review+
Comment 30•22 years ago
|
||
Comment on attachment 101183 [details] [diff] [review]
little patch to fix the typo
Checked in.
Reporter | ||
Comment 31•20 years ago
|
||
I'm not sure when it happened, but this is back to not working again. (See
testcase)
Comment 32•20 years ago
|
||
WD, is this still an issue in current builds? The testcase worksforme in Linux
trunk build 2004-08-06-05....
Reporter | ||
Comment 33•20 years ago
|
||
Ok, this is WFM with a nightly. (Mozilla 1.7.1 doesn't work)
Status: REOPENED → RESOLVED
Closed: 24 years ago → 20 years ago
Resolution: --- → WORKSFORME
Comment 34•20 years ago
|
||
WD, this was 'FIXED' (i.e., it took a patch to fix the problem). FYI, WFM means
that no patch (or sometimes, an unknown patch elsewhere) fixed the problem.
Comment 35•20 years ago
|
||
rbs, that's exactly what happened between 1.7 and now... (this was fixed by a
patch, then regressed, and then unregressed again for unknown reasons).
You need to log in
before you can comment on or make changes to this bug.
Description
•