FF3b1 & latest nightly. The Manage Add-ons button in the Preferences window does not switch to the Add-ons pane when opening the Add-ons dialog. Steps to reproduce: 1. Open Add-ons manager, and switch to the Plugins tab for example. 2. Close it. 3. Open Preferences. 4. Click Manage Add-ons. Expected Results: the add-ons manager should open with the Add-ons pane selected. Actual Results: The add-ons manager opens with the previously selected pane (in this test, Plugins).

Trivial patch to address this problem. Takes care of both cases when the add-on manager window is already open or a new window should be opened.

Why should we always be switching to the Extension's pane when opening from here but not when opening from the Tools menu?

Well, bug 384956 implemented this new button in the Preferences window. The aim of that bug was to fulfill the ADD-002a and ADD-002b requirements <http://wiki.mozilla.org/Firefox3/Product_Requirements_Document#P2>. Because these requirements address the visibility of add-on configuration UI, and the only type of add-ons which can have configuration UI are extensions, I guess the "Manage Add-ons" button should be focusing on extensions, hence this bug and this patch. :-) If that impression is not valid, then I guess this bug is INVALID. Comments from Robert and Beltzner are welcome.

Comment on attachment 292328 [details] [diff] [review] Patch (v1) r=mano

I agree that "Manage Add-ons" should always take you to the list of add-ons from where you can get to the properties. I think, though that if bug 404024 gets resolved, Tools > Add-ons should default to that new pane.

(In reply to comment #5) > I agree that "Manage Add-ons" should always take you to the list of add-ons > from where you can get to the properties. So, do you think the patch in attachment 292328 [details] [diff] [review] exposes the correct behavior? > I think, though that if bug 404024 gets resolved, Tools > Add-ons should > default to that new pane. This patch does not change the behavior of Tools > Add-ons. Its behavior is currently the last selected pane being active by default. And even if the new pane would be considered the default after bug 404024 lands, I think the "Manage Add-ons" button should still open the add-ons list.

Comment on attachment 292328 [details] [diff] [review] Patch (v1) Perhaps johnath can ui-r this?

Comment on attachment 292328 [details] [diff] [review] Patch (v1) Yeah, I think this is right.

Comment on attachment 292328 [details] [diff] [review] Patch (v1) This is fairly trivial, asking for approval to land it.

Comment on attachment 292328 [details] [diff] [review] Patch (v1) Thanks!

Checking in browser/components/preferences/main.js; /cvsroot/mozilla/browser/components/preferences/main.js,v <-- main.js new revision: 1.16; previous revision: 1.15 done

https://litmus.mozilla.org/show_test.cgi?id=5161 in-litmus+ Verified FIXED using: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2008012504 Minefield/3.0b3pre Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3pre) Gecko/2008012504 Minefield/3.0b3pre -and- Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008012504 Minefield/3.0b3pre