Closed
Bug 407412
Opened 17 years ago
Closed 17 years ago
create a vm that is setup to build mozillabuild
Categories
(Firefox Build System :: MozillaBuild, task)
Firefox Build System
MozillaBuild
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: bhearsum)
References
Details
Attachments
(2 files, 4 obsolete files)
(deleted),
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
This required some updates to MozillaBuild. Detailed set-up instructions are in a commented atop packageit.py. A couple bugfixes have been included with this.
Attachment #292135 -
Flags: review?(benjamin)
Comment 1•17 years ago
|
||
-# Make an installer
+ Make an installer
Looks like you lost a comment there, fwiw.
Assignee | ||
Comment 2•17 years ago
|
||
thanks for catching that Ted
Attachment #292135 -
Attachment is obsolete: true
Attachment #292137 -
Flags: review?(benjamin)
Attachment #292135 -
Flags: review?(benjamin)
Assignee | ||
Comment 3•17 years ago
|
||
Attachment #292137 -
Attachment is obsolete: true
Attachment #292390 -
Flags: review?(benjamin)
Attachment #292137 -
Flags: review?(benjamin)
Assignee | ||
Updated•17 years ago
|
Priority: -- → P2
Comment 4•17 years ago
|
||
Comment on attachment 292390 [details] [diff] [review]
[checked in] additional fix to make cvs install to the right location
Wow, is that why the upgraded "cvs" never made it into MB 1.1 :-(
Thank you so much for doing this!
Attachment #292390 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 5•17 years ago
|
||
Checking in libiconv-build.patch;
/cvsroot/mozilla/tools/build-environment/win32/libiconv-build.patch,v <-- libiconv-build.patch
new revision: 1.2; previous revision: 1.1
done
Checking in packageit-msys.sh;
/cvsroot/mozilla/tools/build-environment/win32/packageit-msys.sh,v <-- packageit-msys.sh
new revision: 1.4; previous revision: 1.3
done
Checking in packageit.py;
/cvsroot/mozilla/tools/build-environment/win32/packageit.py,v <-- packageit.py
new revision: 1.6; previous revision: 1.5
done
The VM is setup as mozillabuild-builder.build.mozilla.org. Ted and I both have the username/password if anyone else needs it.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 6•17 years ago
|
||
This patch broke DLL rebasing. Patch to fix that coming soon..
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Updated•17 years ago
|
Attachment #292390 -
Attachment description: additional fix to make cvs install to the right location → [checked in] additional fix to make cvs install to the right location
Assignee | ||
Comment 7•17 years ago
|
||
Attachment #292638 -
Flags: review?(benjamin)
Comment 8•17 years ago
|
||
Comment on attachment 292638 [details] [diff] [review]
make sure DLLs get rebased
-find "${MSYS_STAGEDIR}/mozilla-build/lib" -name "*.dll" | \
+find "${MSYS_STAGEDIR}/mozilla-build" -name "*.dll" | \
+ grep -v "libW11.dll" | \
xargs rebase -d -b 60000000
Had to make this change to get things working with this patch. It just skips rebasing libW11.dll. I haven't tried a full build with this environment, so we may need to skip any other DLLs that fail rebasing, I think rebase breaks them.
Assignee | ||
Comment 9•17 years ago
|
||
We also need to except sqlite3.dll, tclpip84.dll, and any msvs DLLs hanging around there.
Assignee | ||
Comment 10•17 years ago
|
||
This patch excepts the DLLs in the above comments. In the original patch I had a try/catch block around packageit-msys.sh. Now that rebase should not fail (and if it does, it should be a legitimate failure), that's not needed.
Attachment #292638 -
Attachment is obsolete: true
Attachment #293507 -
Flags: review?(benjamin)
Attachment #292638 -
Flags: review?(benjamin)
Updated•17 years ago
|
Attachment #293507 -
Flags: review?(benjamin) → review+
Comment 11•17 years ago
|
||
This fixes all the rebasing issues for me. It rebases all the MSYS DLLs, then specifically rebases msys-1.0.dll to a location slightly above the rest. It's not pretty, but it works.
Attachment #293507 -
Attachment is obsolete: true
Attachment #293929 -
Flags: review?(benjamin)
Assignee | ||
Comment 12•17 years ago
|
||
Mass re-assign of MozillaBuild bugs into mozilla.org:MozillaBuild
Component: Build & Release → MozillaBuild
Updated•17 years ago
|
Priority: P2 → --
QA Contact: build → mozillabuild
Comment 13•17 years ago
|
||
Comment on attachment 293929 [details] [diff] [review]
fix rebasing, seriously
You could probably use "find -name "*.dll" -a -not -name "libW11.dll" but the grep probably works just as well.
Attachment #293929 -
Flags: review?(benjamin) → review+
Comment 14•17 years ago
|
||
Checked in the last patch.
Status: REOPENED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → FIXED
Updated•2 years ago
|
Product: mozilla.org → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•