See the image, it looks distorted when the animation is at the right side. This regressed between 2007-11-17 and 2007-11-18: Regression from bug 403363.

Patch coming up. When the frame is clipped the source pixels are not copied in the right way to the destination frame.

The patch from the other bug did ensure that the image didn't crash on clipped frames, but those frames were not drawn correctly.

Note with this patch the second corrupted image of bug 403363 now looks much better also: https://bugzilla.mozilla.org/attachment.cgi?id=288296

We should probably take this patch w/ Stuart's review. +'ing with P2.

Comment on attachment 293100 [details] [diff] [review] V1: Really do the clipping in the right way stuart's review should be enough here, especially since he's the module owner.

Comment on attachment 293100 [details] [diff] [review] V1: Really do the clipping in the right way stuart's review should be enough here, especially since he's the module owner.

Checking in modules/libpr0n/src/imgContainer.cpp; /cvsroot/mozilla/modules/libpr0n/src/imgContainer.cpp,v <-- imgContainer.cpp new revision: 1.63; previous revision: 1.62 done

It is difficult to see, as the animation is quite quick, but there is no more distortion in the current build: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.11) Gecko/20071127 Firefox/2.0.0.11

(In reply to comment #8) > It is difficult to see, as the animation is quite quick, but there is no more > distortion in the current build: > Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.11) Gecko/20071127 > Firefox/2.0.0.11 Firefox 2.0.0.11? I don't think it has this problem or patch! :)

Oops, copied the wrong build id: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2007122105 Minefield/3.0b3pre