Closed
Bug 408292
Opened 17 years ago
Closed 17 years ago
"ASSERTION: lost track of line breaks somehow" with -moz-column, text-transform, rtl
Categories
(Core :: Layout: Text and Fonts, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jruderman, Assigned: smontagu)
References
Details
(Keywords: assertion, rtl, testcase)
Attachments
(2 files, 1 obsolete file)
|
(deleted),
text/html
|
Details | |
|
(deleted),
patch
|
smontagu
:
review+
smontagu
:
superreview+
mtschrep
:
approval1.9+
|
Details | Diff | Splinter Review |
Loading the testcase triggers:
###!!! ASSERTION: lost track of line breaks somehow: 'nextLineBreak == aTextRun->mLineBreaks.Length()', file /Users/jruderman/trunk/mozilla/layout/generic/nsTextRunTransformations.cpp, line 462
|
Assignee | |
Comment 1•17 years ago
|
||
This is probably because we don't do bidi resolution quite right across column boundaries. I think all the stuff that was blocking fixing that when we talked about it a few months ago has meanwhile been fixed.
Assignee: nobody → smontagu
|
|
Assignee | |
Comment 2•17 years ago
|
||
Attachment #293535 -
Flags: superreview?(roc)
Attachment #293535 -
Flags: review?(roc)
Comment on attachment 293535 [details] [diff] [review]
Include all continuation blocks in the array of text frames
wow, that looks easy!
Attachment #293535 -
Flags: superreview?(roc)
Attachment #293535 -
Flags: superreview+
Attachment #293535 -
Flags: review?(roc)
Attachment #293535 -
Flags: review+
|
|
Assignee | |
Comment 4•17 years ago
|
||
Robert, do you have a testcase which requires the offset fixups at http://mxr.mozilla.org/seamonkey/source/layout/generic/nsTextFrameThebes.cpp#6020 ? It may be possible to convert them to assertions already.
Not at my fingertips, but the CVS log should show you the bugs with the testcases that led to those fixups.
|
|
Assignee | |
Comment 6•17 years ago
|
||
Comment on attachment 293535 [details] [diff] [review]
Include all continuation blocks in the array of text frames
Too easy, apparently: this regresses a couple of the new crashtests. Go Jesse.
Attachment #293535 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 7•17 years ago
|
||
It wasn't really a regression, I was just missing a trivial null-check. In other words, our test suites are catching faults above and beyond the bugs they are actually testing for :)
Transferring r+sr=roc.
Attachment #293692 -
Flags: superreview+
Attachment #293692 -
Flags: review+
|
||
Updated•17 years ago
|
Attachment #293692 -
Flags: approval1.9?
|
||
Updated•17 years ago
|
Attachment #293692 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Comment 8•17 years ago
|
||
Checked in with the testcase as a crashtest.
Status: NEW → RESOLVED
Closed: 17 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
|
||
Comment 9•17 years ago
|
||
Mass-assigning the new rtl keyword to RTL-related (see bug 349193).
Keywords: rtl
You need to log in
before you can comment on or make changes to this bug.
Description
•