Closed Bug 408310 Opened 17 years ago Closed 17 years ago

20071213 trunk crash when visiting protopage.com @ all platforms

Categories

(Core :: Graphics: ImageLib, defect, P2)

Product:
Core
Component:
Graphics: ImageLib
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9beta3

People

(Reporter: c.levin, Assigned: alfredkayser)

References

(
URL
)

Details

(Keywords: crash, regression)

Attachments

(1 file)

V1: Make sure to use the right paletteSize to prevent crashes...
(deleted), patch
pavlov
: review+
tor
: superreview+
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2pre) Gecko/2007121017 Minefield/3.0b2pre Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2007121304 Minefield/3.0b3pre everything was fine with all previous nightly build, but 2007121304 build crash everytime when I visit protopage.com, on all platforms, windiws vista, mac osx tiger, linux (PCLinuxOS4, EEEpc-xandros-easy mode). something changed about how javascripts are interpreted? Reproducible: Always Steps to Reproduce: 1.goto www.protopage.com 2.firefox crashes Actual Results: firefoc crashes Expected Results: should display page properly, as all previous version (release or nightly build)
based on hourly builds: stable: 20071212_0853 crashes: 20071212_0923 http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1197478380&maxdate=1197480179 bug 406626 ? or bug 403578 ?
Severity: normal → critical
Status: UNCONFIRMED → NEW
Ever confirmed: true
Product: Firefox → Core
Version: unspecified → Trunk
Flags: blocking1.9?
Backing out bug 403578 fixes the crash for me (Firefox debug build on Linux).
Blocks: 403578
Flags: in-testsuite?
Keywords: crash, regression
Component: General → Image: GFX
QA Contact: general → image.gfx
Status: NEW → ASSIGNED
Found the issue. For GIF's with a tpixel outside the valid colormap, the realDepth was adjusted, but still for local_colormap the old value was used. And, the memset to clear the extra space in the colormap was also coded wrong, causing the actual crash. Patch coming up...
Assignee: nobody → alfredkayser
Status: ASSIGNED → NEW
Attachment #293107 - Flags: review?(pavlov)
Attachment #293107 - Flags: superreview?(tor)
Confirming that neither the page from this bug nor the page from bug 408444 crashes with the v1 patch applied to the current trunk on XPSP2.
Attachment #293107 - Flags: review?(pavlov) → review+
Flags: blocking1.9? → blocking1.9+
Priority: -- → P2
Status: NEW → ASSIGNED
Component: Image: GFX → ImageLib
QA Contact: image.gfx → imagelib
Attachment #293107 - Flags: superreview?(tor) → superreview+
Keywords: checkin-needed
Checking in modules/libpr0n/src/imgContainer.cpp; /cvsroot/mozilla/modules/libpr0n/src/imgContainer.cpp,v <-- imgContainer.cpp new revision: 1.62; previous revision: 1.61 done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M11
Er, the last comment was for the wrong bug. This the correct commit log: Checking in modules/libpr0n/decoders/gif/nsGIFDecoder2.cpp; /cvsroot/mozilla/modules/libpr0n/decoders/gif/nsGIFDecoder2.cpp,v <-- nsGIFDecoder2.cpp new revision: 1.89; previous revision: 1.88 done
Confirmed that with this patch is doesn't crash anymore: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2007122005 Minefield/3.0b3pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: