Closed Bug 408431 Opened 17 years ago Closed 17 years ago

"ASSERTION: nsVoidArray::FastElementAt: index out of range" with navigator.pendingOfflineLoads[0]

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set
critical

Tracking

()

RESOLVED FIXED

People

(Reporter: jruderman, Assigned: jruderman)

References

Details

(Keywords: assertion, crash, testcase)

Attachments

(2 files)

Loading the testcase triggers:

###!!! ASSERTION: nsVoidArray::FastElementAt: index out of range: '0 <= aIndex && aIndex < Count()', file ../../dist/include/xpcom/nsVoidArray.h, line 72

It then crashes, but only because the array is empty and therefore based at 0x0.  If the array were not empty, I think it would go past the end of the array.

Looks like a simple off-by-one error in nsDOMOfflineLoadStatusList::Item.  I'll attach a patch in a few minutes.
Flags: blocking1.9?
Attached patch patch (deleted) — Splinter Review
Attachment #293229 - Flags: superreview?(jst)
Attachment #293229 - Flags: review?(dcamp)
Attachment #293229 - Flags: review?(dcamp) → review+
Attachment #293229 - Flags: superreview?(jst)
Attachment #293229 - Flags: superreview+
Attachment #293229 - Flags: approval1.9+
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: blocking1.9? → in-testsuite+
Resolution: --- → FIXED
No assertions on the 1.8 branch.
Group: security
Flags: wanted1.8.1.x-
Component: DOM: Mozilla Extensions → DOM
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: