Oleg Romashin (:romaxa) Assignee
	Description • 17 years ago

gtkmozembed contain  randomly styled include quotes

#include <nsXPIDLString.h>
#include "nsXPIDLString.h"

this patch supposed to change mozilla includes into " ", and system in <>

	Marco Pesenti Gritti
	Comment 1 • 17 years ago

Comment on attachment 293505 [details] [diff] [review]
Fix

The patch looks good, but I get several rejects when applying it. Can you please it update it to the latest trunk?

	Marco Pesenti Gritti
	Comment 3 • 17 years ago

Comment on attachment 299812 [details] [diff] [review]
Updated to trunk

romaxa, do you have cvs access or do you want me to land the patch?

	Oleg Romashin (:romaxa) Assignee
	Comment 4 • 17 years ago

Yes I have CVS access but I never used it for committing in trunk?
Can I do it by self?
  

	Reed Loden [:reed]
	Comment 5 • 17 years ago

(In reply to comment #3)
> (From update of attachment 299812 [details] [diff] [review])
> romaxa, do you have cvs access or do you want me to land the patch?

As per http://wiki.mozilla.org/TreeStatus, _all_ patches that are part of the build require approval1.9+ on the patch or the bug must be a blocker before the patch can land.

(In reply to comment #4)
> Yes I have CVS access but I never used it for committing in trunk?
> Can I do it by self?

No, you may not, as your access is restricted to the (now-defunct) MICROB branch. If you wish to commit elsewhere, you will need to follow the normal procedure for getting CVS access by getting appropriate vouchers and a super-reviewer to vouch for you.

	Oleg Romashin (:romaxa) Assignee
	Comment 6 • 17 years ago

> No, you may not, as your access is restricted to the (now-defunct) MICROB

No, I have trunk write access, but I never used it.

> branch. If you wish to commit elsewhere, you will need to follow the normal
> procedure for getting CVS access by getting appropriate vouchers and a
> super-reviewer to vouch for you.

I did it already, see Bug 359594.

	Oleg Romashin (:romaxa) Assignee
	Comment 7 • 17 years ago

Oh, yep, according to https://bugzilla.mozilla.org/show_bug.cgi?id=359594#c4

I have restricted access..

	Marco Pesenti Gritti
	Comment 8 • 17 years ago

Comment on attachment 299812 [details] [diff] [review]
Updated to trunk

No risk cleanup.

	Damon Sicore (:damons)
	Comment 9 • 17 years ago

Comment on attachment 299812 [details] [diff] [review]
Updated to trunk

a1.9+=damons

	Reed Loden [:reed]
	Comment 10 • 17 years ago

Checking in embedding/browser/gtk/src/EmbedContentListener.h;
/cvsroot/mozilla/embedding/browser/gtk/src/EmbedContentListener.h,v  <--  EmbedContentListener.h
new revision: 1.10; previous revision: 1.9
done
Checking in embedding/browser/gtk/src/EmbedEventListener.cpp;
/cvsroot/mozilla/embedding/browser/gtk/src/EmbedEventListener.cpp,v  <--  EmbedEventListener.cpp
new revision: 1.19; previous revision: 1.18
done
Checking in embedding/browser/gtk/src/EmbedEventListener.h;
/cvsroot/mozilla/embedding/browser/gtk/src/EmbedEventListener.h,v  <--  EmbedEventListener.h
new revision: 1.11; previous revision: 1.10
done
Checking in embedding/browser/gtk/src/EmbedPrivate.cpp;
/cvsroot/mozilla/embedding/browser/gtk/src/EmbedPrivate.cpp,v  <--  EmbedPrivate.cpp
new revision: 1.93; previous revision: 1.92
done
Checking in embedding/browser/gtk/src/EmbedPrivate.h;
/cvsroot/mozilla/embedding/browser/gtk/src/EmbedPrivate.h,v  <--  EmbedPrivate.h
new revision: 1.47; previous revision: 1.46
done
Checking in embedding/browser/gtk/src/EmbedProgress.cpp;
/cvsroot/mozilla/embedding/browser/gtk/src/EmbedProgress.cpp,v  <--  EmbedProgress.cpp
new revision: 1.27; previous revision: 1.26
done
Checking in embedding/browser/gtk/src/EmbedProgress.h;
/cvsroot/mozilla/embedding/browser/gtk/src/EmbedProgress.h,v  <--  EmbedProgress.h
new revision: 1.10; previous revision: 1.9
done
Checking in embedding/browser/gtk/src/EmbedPrompter.h;
/cvsroot/mozilla/embedding/browser/gtk/src/EmbedPrompter.h,v  <--  EmbedPrompter.h
new revision: 1.12; previous revision: 1.11
done
Checking in embedding/browser/gtk/src/EmbedWindow.cpp;
/cvsroot/mozilla/embedding/browser/gtk/src/EmbedWindow.cpp,v  <--  EmbedWindow.cpp
new revision: 1.44; previous revision: 1.43
done
Checking in embedding/browser/gtk/src/EmbedWindow.h;
/cvsroot/mozilla/embedding/browser/gtk/src/EmbedWindow.h,v  <--  EmbedWindow.h
new revision: 1.19; previous revision: 1.18
done
Checking in embedding/browser/gtk/src/GtkPromptService.cpp;
/cvsroot/mozilla/embedding/browser/gtk/src/GtkPromptService.cpp,v  <--  GtkPromptService.cpp
new revision: 1.17; previous revision: 1.16
done
Checking in embedding/browser/gtk/src/GtkPromptService.h;
/cvsroot/mozilla/embedding/browser/gtk/src/GtkPromptService.h,v  <--  GtkPromptService.h
new revision: 1.7; previous revision: 1.6
done
Checking in embedding/browser/gtk/src/gtkmozembed2.cpp;
/cvsroot/mozilla/embedding/browser/gtk/src/gtkmozembed2.cpp,v  <--  gtkmozembed2.cpp
new revision: 1.65; previous revision: 1.64
done
Checking in embedding/browser/gtk/src/gtkmozembed_internal.h;
/cvsroot/mozilla/embedding/browser/gtk/src/gtkmozembed_internal.h,v  <--  gtkmozembed_internal.h
new revision: 1.14; previous revision: 1.13
done