Oleg Romashin (:romaxa) Assignee
	Description • 17 years ago

DOMPopupBlocked signal for gtkmozembed signals interface

	Marco Pesenti Gritti
	Comment 1 • 17 years ago

Passing the host through the signal seem unnecessary, since it can be derived from the URI.

The signal used in epiphany expose more of the nsIDOMPopupBlockedEvent properties:

void (* popup_blocked) (EphyEmbed *embed,
                        const char *address,
                        const char *target,
                        const char *features);

Looks pretty good to me, but I have a couple of doubts about it:

1 Do we need to expose requestingWindow? I can't think of cases where an embedding application would need to know which child window requested the popup but...
2 Should we encapsulate the popup properties in a GtkMozPopup object to be able to extend them in the future?

	Sylvestre Ledru [:Sylvestre]
	Comment 2 • 6 years ago

Embedding: GTK Widget isn't a thing, closing.