Closed
Bug 408883
Opened 17 years ago
Closed 17 years ago
[FIX]Leak BandRect with -moz-column, float
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9beta3
People
(Reporter: jruderman, Assigned: bzbarsky)
References
Details
(Keywords: memory-leak, testcase)
Attachments
(2 files)
|
(deleted),
text/html
|
Details | |
|
(deleted),
patch
|
roc
:
review+
roc
:
superreview+
sicking
:
approval1.9+
|
Details | Diff | Splinter Review |
Loading the testcase makes Firefox leak a BandRect and nsVoidArray, as shown by trace-refcnt shutdown stats.
|
Reporter | |
Comment 1•17 years ago
|
||
Assignee: nobody → roc
Flags: blocking1.9?
Blocks: mlkTests
|
Assignee | |
Comment 2•17 years ago
|
||
If we weren't planning on removing all this code as soon as we can, I'd change all this to do spiffy nsAutoPtr-ness that would be leak-immune. But I think this will do for now.
Assignee: roc → bzbarsky
Status: NEW → ASSIGNED
Attachment #293804 -
Flags: superreview?(roc)
Attachment #293804 -
Flags: review?(roc)
|
|
Assignee | |
Updated•17 years ago
|
Summary: Leak BandRect with -moz-column, float → [FIX]Leak BandRect with -moz-column, float
Target Milestone: --- → mozilla1.9 M11
Attachment #293804 -
Flags: superreview?(roc)
Attachment #293804 -
Flags: superreview+
Attachment #293804 -
Flags: review?(roc)
Attachment #293804 -
Flags: review+
|
|
Assignee | |
Comment 3•17 years ago
|
||
Comment on attachment 293804 [details] [diff] [review]
Proposed fix
Simple leak fix.
Attachment #293804 -
Flags: approval1.9?
Attachment #293804 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Comment 4•17 years ago
|
||
Fixed. Can we just stick the test into crashtest to detect leaks? Or something else?
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: blocking1.9? → in-testsuite?
Resolution: --- → FIXED
|
||
Comment 5•17 years ago
|
||
That should work; I'd leave the flag at ? until we're actually running crashtests with leaks being fatal, tho, and then we can flip it once the test is running and testing what it's supposed to test.
|
|
Reporter | |
Comment 6•17 years ago
|
||
Crashtest checked in.
Lack of leak testing on Tinderbox is tracked by bug 397724, not by leaving dozens of bugs in an ambiguous "in-testsuite?" state.
Flags: in-testsuite? → in-testsuite+
Though in theory the existing reftest already covered this... We should be checking those for leaks too eventually.
|
|
Reporter | |
Comment 8•17 years ago
|
||
Which existing reftest?
Not sure which exact one, but running the reftest suite shows 5 (iirc) BandRects (and their contained nsVoidArrays) leaked.
You need to log in
before you can comment on or make changes to this bug.
Description
•