Open
Bug 409061
Opened 17 years ago
Updated 2 years ago
"Port" (/suite) bug 223549 to /browser: sync with /mail too
Categories
(Core :: General, defect)
Core
General
Tracking
()
NEW
People
(Reporter: sgautherie, Unassigned)
References
Details
(Keywords: helpwanted)
Reporter | ||
Comment 1•17 years ago
|
||
Well, porting bug 223549 would make </toolkit/content/contentAreaUtils.js> "depend" on </browser/base/content/utilityOverlay.js>, which works but doesn't sound good :-/
I think /mail and /suite should use |validateFileName()| from </toolkit/content/contentAreaUtils.js> rather than from their own (copy in) <.../utilityOverlay.js> !
But I don't know how to achieve this (nicely) ? (helpwanted)
Keywords: helpwanted
Comment 2•17 years ago
|
||
(In reply to comment #1)
>I think /mail and /suite should use |validateFileName()| from
></toolkit/content/contentAreaUtils.js> rather than from their own (copy in)
><.../utilityOverlay.js> !
>But I don't know how to achieve this (nicely) ? (helpwanted)
You would have to look at all the functions in toolkit's contentAreaUtils.js and see if they can safely replace the functions of the same name in mail/suite, so that they can be removed and contentAreaUtils.js loaded instead.
Reporter | ||
Comment 3•17 years ago
|
||
(In reply to comment #2)
> You would have to look at all the functions in toolkit's contentAreaUtils.js
> and see if they can safely replace the functions of the same name in
> mail/suite, so that they can be removed and contentAreaUtils.js loaded instead.
Bug 405563 looks like a step toward this ;->
(Yet, it's a kind of catch-22 for now: see bug 409112 for example.)
For the current bug, would creating a ("minimal") Toolkit <utilityOverlay.js> make any sense ?
Reporter | ||
Comment 4•17 years ago
|
||
Comment 5•17 years ago
|
||
(In reply to comment #3)
>For the current bug, would creating a ("minimal") Toolkit <utilityOverlay.js>
>make any sense ?
I'm not sure what you're suggesting, but it doesn't seem to make sense to me.
Reporter | ||
Comment 6•17 years ago
|
||
(In reply to comment #5)
> I'm not sure what you're suggesting, but it doesn't seem to make sense to me.
To create a </toolkit/content/utilityOverlay.js> file,
with (at least) |GenerateValidFilename()| and |validateFileName()|.
Comment 7•17 years ago
|
||
Sorry, but I wouldn't have thought that would be appreciated.
Updated•10 years ago
|
Target Milestone: mozilla1.9beta3 → ---
Updated•2 years ago
|
Severity: trivial → S4
You need to log in
before you can comment on or make changes to this bug.
Description
•