Closed
Bug 409114
Opened 17 years ago
Closed 17 years ago
Share ssh-agent instances across rxvt instances
Categories
(Firefox Build System :: MozillaBuild, task)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bent.mozilla, Assigned: bent.mozilla)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Right now there are two instances of ssh-agent that get created per instance of rxvt. Attached patch uses a script that I found here:
http://www.cygwin.com/ml/cygwin/2001-06/msg00537.html
Attachment #293962 -
Flags: review?(ted.mielczarek)
|
Assignee | |
Comment 1•17 years ago
|
||
I guess the bad thing about this is that the single instance of ssh-agent will live forever (until shutdown)... but it's pretty small so I dont think anyone will really care. This makes it so that you only have to enter your password once per login session.
|
||
Comment 2•17 years ago
|
||
Comment on attachment 293962 [details] [diff] [review]
Patch
>+ ps -ef | grep ${SSH_AGENT_PID} | grep ssh-agent$ > /dev/null || {
FWIW, $SSH_AGENT_PID will work on MSYS afaict. Probably doesn't matter but I just wanted to mention it.
|
|
Assignee | |
Comment 3•17 years ago
|
||
I emailed the script author asking for licensing permission.
|
||
Updated•17 years ago
|
Component: Build & Release → MozillaBuild
QA Contact: build → mozillabuild
|
|
||
Updated•17 years ago
|
Assignee: nobody → bent.mozilla
|
|
||
Comment 4•17 years ago
|
||
Comment on attachment 293962 [details] [diff] [review]
Patch
r+ but pending licensing I guess. :-/
Attachment #293962 -
Flags: review?(ted.mielczarek) → review+
|
||
Comment 5•17 years ago
|
||
This patch doesn't fix the newly born start-l10n.bat, too.
|
|
Assignee | |
Comment 6•17 years ago
|
||
That file looks ok to me... I'm removing the ssh-agent lines from the others and start-l10n.bat doesn't have any reference to ssh-agent.
|
|
||
Comment 7•17 years ago
|
||
Hrm. That seems to be a double merge error. Myk landed ssh-agent support for all but one start script, start-msvc9.bat, which I used to create start-l10n.bat, for no particular reason.
Sounds like a good idea to sync all the start scripts in this regard.
|
|
Assignee | |
Comment 8•17 years ago
|
||
That's what this patch will do - I'm backing out Myk's ssh-agent additions and then adding a profile script to do the real ssh-agent work. You got lucky :)
|
|
||
Comment 9•17 years ago
|
||
Gosh, I blame the elves for me not reading. Sorry.
|
|
Assignee | |
Comment 10•17 years ago
|
||
Ted, Joseph Reagle contacted me via email and released the script under the GPL. Need a new patch or can I just add that on checkin?
|
|
||
Comment 11•17 years ago
|
||
Just add it, that's fine.
|
|
Assignee | |
Comment 12•17 years ago
|
||
Fixed on trunk.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
|
||
Comment 13•17 years ago
|
||
Mass re-assign of MozillaBuild bugs into mozilla.org:MozillaBuild
|
||
Updated•2 years ago
|
Product: mozilla.org → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•